Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen #2254

Merged
merged 1 commit into from
Sep 5, 2019
Merged

codegen #2254

merged 1 commit into from
Sep 5, 2019

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Sep 5, 2019

Something wacky in going on with codegen.

@alexec alexec requested a review from alexmt September 5, 2019 21:34
@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #2254 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2254      +/-   ##
==========================================
- Coverage    37.9%   37.84%   -0.07%     
==========================================
  Files          98       98              
  Lines       13805    13805              
==========================================
- Hits         5233     5224       -9     
- Misses       7888     7901      +13     
+ Partials      684      680       -4
Impacted Files Coverage Δ
controller/appcontroller.go 44.11% <0%> (-1.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b42389a...be19173. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Sep 5, 2019 •
edited
Loading

Codecov Report

Merging #2254 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2254      +/-   ##
==========================================
- Coverage    37.9%   37.84%   -0.07%     
==========================================
  Files          98       98              
  Lines       13805    13805              
==========================================
- Hits         5233     5224       -9     
- Misses       7888     7901      +13     
+ Partials      684      680       -4
Impacted Files Coverage Δ
controller/appcontroller.go 44.11% <0%> (-1.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b42389a...be19173. Read the comment docs.

@alexec alexec marked this pull request as ready for review September 5, 2019 21:51
@alexec alexec merged commit b37be09 into argoproj:master Sep 5, 2019
@alexec alexec deleted the codegen branch September 5, 2019 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexec @alexmt