-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: New kube applier for server side diff dry run with refactoring (#21488) #21749
fix: New kube applier for server side diff dry run with refactoring (#21488) #21749
Conversation
…rgoproj#21488) Fixes: argoproj#21488 Use the new kube applier from gitops engine, which avoid the error arising from concatenating kube command stderr to stdout. Needs to be cherry-picked to v2.14. Signed-off-by: Andrii Korotkov <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Andrii Korotkov <[email protected]>
Signed-off-by: Andrii Korotkov <[email protected]>
Signed-off-by: Andrii Korotkov <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21749 +/- ##
==========================================
+ Coverage 55.63% 55.65% +0.02%
==========================================
Files 339 339
Lines 56812 56826 +14
==========================================
+ Hits 31609 31629 +20
+ Misses 22553 22546 -7
- Partials 2650 2651 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andrii Korotkov <[email protected]>
Signed-off-by: Andrii Korotkov <[email protected]>
Signed-off-by: Andrii Korotkov <[email protected]>
Signed-off-by: Andrii Korotkov <[email protected]>
Signed-off-by: Andrii Korotkov <[email protected]>
…f-dry-run-with-refactoring Signed-off-by: Andrii Korotkov <[email protected]>
Signed-off-by: Andrii Korotkov <[email protected]>
Signed-off-by: Andrii Korotkov <[email protected]>
Signed-off-by: Andrii Korotkov <[email protected]>
Signed-off-by: Andrii Korotkov <[email protected]>
…f-dry-run-with-refactoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…rgoproj#21488) (argoproj#21749) Signed-off-by: Andrii Korotkov <[email protected]>
Cherry pick PR for 2.14 #21819 |
Fixes: #21488
Use the new kube applier from gitops engine, which avoid the error arising from concatenating kube command stderr to stdout.
Needs to be cherry-picked to v2.14, but need a manual PR due to referencing v3 vs v2.
Checklist: