feat(metrics): add more kubectl metrics #21720
Draft
+521
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <[email protected]>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
leoluz
reviewed
Jan 31, 2025
util/metrics/kubectl_metrics.go
Outdated
| Name: "argocd_kubectl_transport_create_calls_total", | ||
| Help: "Number of kubectl transport create calls", | ||
| }, | ||
| []string{"initiator", "result"}, |
There was a problem hiding this comment.
What is the value the "result" label will have?
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
…d it'll probably be fine anyway Signed-off-by: Michael Crenshaw <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21720 +/- ##
==========================================
+ Coverage 55.59% 55.73% +0.14%
==========================================
Files 339 341 +2
Lines 57346 56922 -424
==========================================
- Hits 31881 31727 -154
+ Misses 22784 22546 -238
+ Partials 2681 2649 -32 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very much a PoC. I noticed client-go provides some metrics we're not yet surfacing. I'm not a metrics wonk, so I'm not sure how the cost of these metrics compares to the value. I tried to keep cardinality low where possible. Please let me know your thoughts!