chore!: remove legacy repo support (#19768) #21249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Michael Crenshaw <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21249 +/- ##
==========================================
+ Coverage 55.59% 55.67% +0.07%
==========================================
Files 340 339 -1
Lines 57419 56802 -617
==========================================
- Hits 31924 31625 -299
+ Misses 22807 22531 -276
+ Partials 2688 2646 -42 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Crenshaw <[email protected]>
crenshaw-dev
changed the title
…backend Signed-off-by: Michael Crenshaw <[email protected]>
…backend Signed-off-by: Michael Crenshaw <[email protected]>
…backend Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
…backend Signed-off-by: Michael Crenshaw <[email protected]>
…backend Signed-off-by: Michael Crenshaw <[email protected]>
agaudreault
requested changes
Feb 3, 2025
cmd/argocd/commands/admin/backup.go
Outdated
Comment on lines
205
to
210
| secrets, err := acdClients.secrets.List(ctx, metav1.ListOptions{}) | ||
| errors.CheckError(err) | ||
| for _, secret := range secrets.Items { | ||
| if isArgoCDSecret(referencedSecrets, secret) { | ||
| pruneObjects[kube.ResourceKey{Group: "", Kind: "Secret", Name: secret.GetName(), Namespace: secret.GetNamespace()}] = secret | ||
| } |
There was a problem hiding this comment.
Argo is creating the resources from the UI as k8s Secret resource. I think we have to import/export them as part of the backup whenever they contain the argo-cd annotation/label
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
agaudreault
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19768