fix: Stop appending :443 to the server address when using grpc-web (cherry-pick #15435) #15470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
Signed-off-by: David Marby <[email protected]> Co-authored-by: jannfis <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## release-2.8 #15470 +/- ##
===============================================
- Coverage 49.94% 49.94% -0.01%
===============================================
Files 263 263
Lines 45063 45061 -2
===============================================
- Hits 22508 22505 -3
Misses 20347 20347
- Partials 2208 2209 +1
☔ View full report in Codecov by Sentry. |
jannfis
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked Stop appending :443 to the server address when using grpc-web (#15435)
Signed-off-by: David Marby [email protected]
Co-authored-by: jannfis [email protected]