Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appset): Revert applicationset-name labels (cherry-pick #15324) #15422

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked fix(appset): Revert applicationset-name labels (#15324)

  • fix(15282) Revert applicationset-name labels

Signed-off-by: gmuselli [email protected]

  • fix(15282) fix unit test

Signed-off-by: gmuselli [email protected]


Signed-off-by: gmuselli [email protected]

* fix(15282) Revert applicationset-name labels

Signed-off-by: gmuselli <[email protected]>

* fix(15282) fix unit test

Signed-off-by: gmuselli <[email protected]>

---------

Signed-off-by: gmuselli <[email protected]>
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (77556d9) 49.94% compared to head (5a31885) 49.93%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.8   #15422      +/-   ##
===============================================
- Coverage        49.94%   49.93%   -0.02%     
===============================================
  Files              263      263              
  Lines            45067    45063       -4     
===============================================
- Hits             22508    22501       -7     
- Misses           20350    20352       +2     
- Partials          2209     2210       +1     
Files Changed Coverage Δ
...cationset/controllers/applicationset_controller.go 62.68% <ø> (-0.15%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannfis jannfis merged commit c698426 into release-2.8 Sep 8, 2023
@jannfis jannfis deleted the cherry-pick-c07dbf-release-2.8 branch September 8, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants