Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmp): pass env to plugin discovery (#13950) #13947

Merged
merged 3 commits into from
Mar 26, 2024
Merged

fix(cmp): pass env to plugin discovery (#13950) #13947

merged 3 commits into from
Mar 26, 2024

Conversation

crenshaw-dev
Copy link
Member

@crenshaw-dev crenshaw-dev commented Jun 7, 2023 •
edited
Loading

Fixes #13950

@crenshaw-dev crenshaw-dev mentioned this pull request Jun 7, 2023
Closed
3 tasks
@crenshaw-dev crenshaw-dev changed the title fix(cmp): pass env to plugin discovery fix(cmp): pass env to plugin discovery (#13950) Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.58%. Comparing base (05eea87) to head (56f0d18).
Report is 40 commits behind head on master.

❗ Current head 56f0d18 differs from pull request most recent head a75801b. Consider uploading reports for the commit a75801b to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #13947      +/-   ##
==========================================
+ Coverage   49.44%   49.58%   +0.13%     
==========================================
  Files         273      256      -17     
  Lines       48662    43930    -4732     
==========================================
- Hits        24063    21783    -2280     
+ Misses      22237    19985    -2252     
+ Partials     2362     2162     -200

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev marked this pull request as ready for review July 14, 2023 20:01
@crenshaw-dev crenshaw-dev requested a review from a team as a code owner March 21, 2024 21:11
jannfis
jannfis approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannfis jannfis merged commit 1bddee2 into argoproj:master Mar 26, 2024
27 checks passed
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
@crenshaw-dev @blakepettersson
@jannfis @lyda
fix(cmp): pass env to plugin discovery (argoproj#13947)
f47bf48 
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Blake Pettersson <[email protected]>
Co-authored-by: Jann Fischer <[email protected]>
Signed-off-by: Kevin Lyda <[email protected]>
mkieweg pushed a commit to mkieweg/argo-cd that referenced this pull request Jun 11, 2024
@crenshaw-dev @blakepettersson
@jannfis @mkieweg
fix(cmp): pass env to plugin discovery (argoproj#13947)
6a1d619 
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Blake Pettersson <[email protected]>
Co-authored-by: Jann Fischer <[email protected]>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@crenshaw-dev @blakepettersson
@jannfis @Hariharasuthan99
fix(cmp): pass env to plugin discovery (argoproj#13947)
8d0df87 
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Blake Pettersson <[email protected]>
Co-authored-by: Jann Fischer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jannfis jannfis jannfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMP discovery doesn't get the ARGOCD_* env
3 participants
@crenshaw-dev @jannfis @blakepettersson