Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update redis #12231

Closed
wants to merge 9 commits into from
Closed

chore: update redis #12231

wants to merge 9 commits into from

Conversation

emirot
Copy link
Contributor

@emirot emirot commented Jan 31, 2023

Signed-off-by: emirot [email protected]

Previously discussed in #10674

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: emirot <[email protected]>
Signed-off-by: emirot <[email protected]>
@emirot emirot changed the title chore: update redis DRAFTchore: update redis Jan 31, 2023
@emirot emirot changed the title DRAFTchore: update redis Draft: chore: update redis Jan 31, 2023
@emirot emirot changed the title Draft: chore: update redis chore: update redis Jan 31, 2023
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Patch coverage: 50.00% and no project coverage change

Comparison is base (0f500a5) 47.79% compared to head (c5191b1) 47.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12231   +/-   ##
=======================================
  Coverage   47.79%   47.79%           
=======================================
  Files         246      246           
  Lines       41968    41980   +12     
=======================================
+ Hits        20058    20064    +6     
- Misses      19910    19916    +6     
  Partials     2000     2000           
Impacted Files Coverage Δ
cmd/argocd/commands/admin/cluster.go 0.00% <ø> (ø)
reposerver/cache/cache.go 61.02% <ø> (ø)
server/cache/cache.go 61.53% <ø> (ø)
server/server.go 55.51% <ø> (ø)
util/cache/appstate/cache.go 65.38% <ø> (ø)
util/cache/cache.go 51.18% <ø> (ø)
util/cache/redis.go 50.44% <0.00%> (-2.83%) ⬇️
util/session/state.go 68.91% <ø> (ø)
util/cache/redis_hook.go 70.00% <100.00%> (+12.85%) ⬆️
util/settings/settings.go 49.36% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@emirot emirot closed this Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant