Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kustomize 2.0 support #1085

Closed
jessesuen opened this issue Feb 2, 2019 · 4 comments
Closed

Kustomize 2.0 support #1085

jessesuen opened this issue Feb 2, 2019 · 4 comments
Assignees
Milestone

Comments

@jessesuen
Copy link
Member

Kustomize 2 is radically different and has many breaking changes, including to the CLI. It's very likely Argo CD will need to simultaneously support both versions for some time, and selectively choose the correct CLI based on the detected version of the kustomization.yaml.

@jessesuen jessesuen added this to the v0.12 milestone Feb 12, 2019
@jessesuen
Copy link
Member Author

Targeting v0.12 since Kustomize 2 is released.

@jessesuen jessesuen added the P1 label Feb 14, 2019
@jessesuen
Copy link
Member Author

jessesuen commented Feb 14, 2019

2.0 differences which we care about:

  • kustomization.yaml requires API version to be specified. This should be used to decide which version of kustomize to invoke.
  • CLI differences with kustomize edit set imagetag (1.0) vs. kustomize edit set image (2.0). Based on kustomization.yaml, this affects how we set user defined parameters before running kustomize build.

Argo CD spec.source.componentParameterOverrides may need to use a different value for the component field. Currently this is imagetag. This may affect how our UI works.

@alexec
Copy link
Contributor

alexec commented Feb 15, 2019

@alexec
Copy link
Contributor

alexec commented Feb 15, 2019

Kustomization filename

In previous versions, the canonical name of a kustomization file is kustomization.yaml. Kustomize 2.0.0 is extended to recognize more file names: kustomization.yaml, kustomization.yml and Kustomization. In a directory, only one of those filenames is allowed. If there are more than one found, Kustomize will exit with an error. Please select the best filename for your use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants