-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 11 support #2473
Laravel 11 support #2473
Conversation
|
I have problems installing this for laravel 11: my composer.json
And get the following error Problem 1 Note: |
@ifox @kfina-planxy, it looks like the remaining packages have been updated 🥳 |
This is because testbench now defaults to the database cache store instead of file, see orchestral/testbench-core@1bb8919#diff-86a4a158399429a6fc000a17b3a8da05fddb1c0c16aab3d8ef00f6c67cb8154dR28. Even though our phpunit is configured to use a mysql database, we need that temporary testing database to avoid failing tests because the cache table doesn't exist during the Twill assets build.
This shouldn't be necessary as this should be coming from Twill's default configuration that is merged in Twill's service provider. This wasn't an issue with previous versions. Not sure yet if the issue is coming from Laravel 11, Dusk or Testbench.
For some reason this isn't needed prior to Laravel 11. Still trying to figure out what has changed in the ecosystem that broke our Dusk tests.
Co-Authored-By: Antonio Ribeiro <[email protected]>
Co-Authored-By: Antonio Ribeiro <[email protected]>
This reverts commit a3a3337.
This reverts commit 05d92d3.
This is so that the vendor symlink is correctly created in Dusk's Laravel skeleton
Patch test case base classes in CI to deal with PHPUnit breaking changes
Very excited to share that Twill 3 has been successfully tested with Laravel 11! Read about Laravel 11 on Laravel News.
We will need these PRs on our dependencies to be merged and released:
This PR can be tested using the following Composer configuration:
The main change in Laravel 11 is the streamlined skeleton. When creating a fresh Laravel 11 application, your repository will contains 69 less files than it would on Laravel 10! Read more about this on Laravel News.
I'm personally very excited by the new config directory behavior, which matches the behavior of Twill's configuration file, where you only need to override what you need, and everything else just inherits from the provided defaults.
It looks so good!