fix a compatibility problem with server.accept() support #88
Conversation
for not updated version of the library server.available() works like server.accept()
|
Are you making it compatible with an older library ? |
yes. even with the current library version. because the library's PR for accept() is not merged yet |
The frame is padded with 0xFF to a multiple of 4, that's why it was always true. I'm not sure why this fix is needed though ? I mean once your PR here arduino-libraries/WiFiNINA#204 is merged, this issue will be fixed with a library update. Fixing this in the firmware now won't matter unless all users update their firmware, which isn't very likely. |
|
if the PR in library is merged then this fix is much less needed. but if it is not merged and a new version of the firmware is published without this fix, then it is a problem. it looks like fw 1.5.0 was not published (at least it is not available in Updater in IDE 1) |
That would be a question for @facchinm |
|
This is no longer required as we'll merge the library fix in arduino-libraries/WiFiNINA#204 |
|
@pennam please read the comments here |
|
now the PR in WiFiNINA is merged so it is ok |
|
Thanks for the heads-up @JAndrassy 👍 I'm checking other open PRs in WiFiNINA, i will release a new version today/tomorrow |
something went wrong when I more than a year ago tested the PR with support for server.accept behavior with a WiFiNINA library version which doesn't have server.accept support yet. I missed that END_CMD in the commandBuffer always sets
acceptto true in availDataTcp. It looked like availDataTcp is all zeros after the last received parameter soacceptwill be false.So now with fw 1.5.0 the server.available() always works like server.accept(), because the current version of the library asks for fw 1.5.0 but doesn't have the PR arduino-libraries/WiFiNINA#204 with support of server.accept merged.