Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle input-object-type definitions #5

Merged
merged 3 commits into from
Nov 14, 2019
Merged

fix: handle input-object-type definitions #5

merged 3 commits into from
Nov 14, 2019

Conversation

YevheniiMelikov
Copy link
Contributor

This pr will add handler for InputObjectTypeDefinition in visitor config.

ardeois
ardeois reviewed Nov 13, 2019
View reviewed changes
Copy link
Owner

@ardeois ardeois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks but can you add a test to see how it will look like?

@ardeois ardeois assigned ardeois and unassigned ardeois Nov 13, 2019
@ardeois ardeois added the patch Increment the patch version when merged label Nov 13, 2019
ardeois
ardeois approved these changes Nov 13, 2019
View reviewed changes
Copy link
Owner

@ardeois ardeois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks for the updates !

@ardeois
Copy link
Owner

ardeois commented Nov 13, 2019

@YevheniiMelikov can you create another commit, I've activated Circle CI for fork pull requests.
If this is not triggering a build, could you try to open a new PR please?
Sorry for the inconvenience but I don't want to merge a PR if the tests are not run by CI

@YevheniiMelikov
Copy link
Contributor Author

@ardeois Done, merge it, please

@ardeois
Copy link
Owner

ardeois commented Nov 14, 2019

Thanks !

@ardeois ardeois merged commit 6447d2c into ardeois:master Nov 14, 2019
@ardeois
Copy link
Owner

ardeois commented Nov 14, 2019

@YevheniiMelikov Version 0.1.2 published !
https://www.npmjs.com/package/graphql-codegen-typescript-mock-data/v/0.1.2

@YevheniiMelikov YevheniiMelikov deleted the fix/input-object-type-support branch November 14, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardeois ardeois ardeois approved these changes

Assignees
No one assigned
Labels
patch Increment the patch version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YevheniiMelikov @ardeois