Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for prefixing types #29

Merged
merged 3 commits into from
Aug 10, 2020
Merged

Add config for prefixing types #29

merged 3 commits into from
Aug 10, 2020

Conversation

RicardoTrindade
Copy link
Contributor

Related with: #28

Allows adding a prefix to the generated types, useful when your types are globally exported (i.e when using the generator add plugin) so you don't need to import them into your files and can call them directly.

@ardeois let me know if implementation looks ok, I can add a couple more tests and then update the README

@RicardoTrindade
Copy link
Contributor Author

Build seems to be failing due to npm being down :(

Copy link
Owner

@ardeois ardeois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but can you update the README documentation as well please?

Also unit tests are failing

@RicardoTrindade
Copy link
Contributor Author

Updated readme and tests. Build should be green but the CI is failing with

Error uploading workspace archive: AccessDenied: Access Denied
	status code: 403, request id: 458839DA71F13E12, host id: s9mwcdA8T5lhi01fpqIRpJBa/OQOPgMZ/5KiaAOzv1rqLZh4Kb41IieldfY92n/QMZ22mkxrSxw=

@ardeois ardeois self-assigned this Aug 10, 2020
@ardeois ardeois added the minor Increment the minor version when merged label Aug 10, 2020
README.md Outdated Show resolved Hide resolved
@ardeois ardeois merged commit 5c9b4cb into ardeois:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants