Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enum values update #120

Merged
merged 1 commit into from
Mar 16, 2023
Merged

fix: enum values update #120

merged 1 commit into from
Mar 16, 2023

Conversation

ardeois
Copy link
Owner

@ardeois ardeois commented Mar 16, 2023

Update enum values generation when it contains underscores to match Typescript generator

  • Will use transformUnderscore config for enum type name only
  • Enum keys underscores are always transformed, whatever the config from transformUnderscore

Update generation when enumsAsTypes is true:

  • We need to keep the value as is because it's the string value to be sent

@ardeois ardeois self-assigned this Mar 16, 2023
Update enum values generation when it contains underscores to match Typescript generator
- Will use `transformUnderscore` config for enum type name only
- Enum keys underscores are always transformed, whatever the config from `transformUnderscore`

Update generation when `enumsAsTypes` is `true`:
- We need to keep the value as is because it's the string value to be sent
@ardeois ardeois force-pushed the fix/enum_values_underscores branch from 6ed2ac7 to 021076e Compare March 16, 2023 19:25
@ardeois ardeois merged commit 95bd83f into main Mar 16, 2023
@ardeois ardeois deleted the fix/enum_values_underscores branch March 16, 2023 19:52
@ardeois ardeois added the minor Increment the minor version when merged label Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant