Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align versions #2082

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Align versions #2082

merged 2 commits into from
Feb 20, 2025

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Feb 20, 2025

Related #2077

Summary by CodeRabbit

  • Chores
    • Updated several core dependency versions to enhance stability, performance, and compatibility.
    • Refined dependency configurations to streamline module behavior without affecting visible functionality.

Copy link

coderabbitai bot commented Feb 20, 2025

Walkthrough

This pull request updates dependency versions across multiple packages. The dependency @whatwg-node/node-fetch is bumped from ^0.7.8 to ^0.7.9, and the dependency @whatwg-node/fetch is updated from ^0.10.0 to ^0.10.3. Additionally, the @whatwg-node/server-plugin-cookies package now has its @whatwg-node/cookie-store dependency updated to allow caret-based versioning, removes an outdated peer dependency on @whatwg-node/server (^0.9.44), and adds a new dependency on @whatwg-node/server at version ^0.9.67.

Changes

Files Change Summary
.changeset/@whatwg-node/node_fetch-2082-dependencies.md
packages/fetch/package.json
Update dependency @whatwg-node/node-fetch from ^0.7.8 to ^0.7.9.
.changeset/@whatwg-node_server-2082-dependencies.md
packages/server/package.json
Update dependency @whatwg-node/fetch from ^0.10.0 to ^0.10.3.
.changeset/@whatwg-node_server-plugin-cookies-2082-dependencies.md
packages/server-plugin-cookies/package.json
Remove peer dependency @whatwg-node/server (^0.9.44), update @whatwg-node/cookie-store to ^0.2.2, and add dependency @whatwg-node/server (^0.9.67).

Possibly related PRs

  • Upcoming Release Changes #2050: Updates the @whatwg-node/node-fetch dependency version, directly relating to the version bump implemented here.
  • Upcoming Release Changes #2032: Modifies the @whatwg-node/node-fetch package by removing a custom AbortSignal implementation, creating a code-level link with the dependency update.

Poem

I'm a rabbit with a code-filled heart,
Hopping through updates, a brand new start.
Dependencies updated, neat and bright,
Leaping through changes, day and night.
Nibble on carrots and bytes in delight! 🥕💻


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@whatwg-node/fetch 0.10.4-alpha-20250220121345-559e23af1fee012d82a99600f796c28c8c111318 npm ↗︎ unpkg ↗︎
@whatwg-node/node-fetch 0.7.10-alpha-20250220121345-559e23af1fee012d82a99600f796c28c8c111318 npm ↗︎ unpkg ↗︎

Copy link
Contributor

@benchmarks/server results (native)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 228202      ✗ 0     
     data_received..................: 23 MB   764 kB/s
     data_sent......................: 9.1 MB  304 kB/s
     http_req_blocked...............: avg=1.43µs   min=841ns    med=1.2µs    max=320.79µs p(90)=1.92µs   p(95)=2.11µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=131.18µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=199.26µs min=141.36µs med=188.06µs max=24.59ms  p(90)=215.2µs  p(95)=226.93µs
       { expected_response:true }...: avg=199.26µs min=141.36µs med=188.06µs max=24.59ms  p(90)=215.2µs  p(95)=226.93µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 114101
     http_req_receiving.............: avg=25.71µs  min=13.8µs   med=24.04µs  max=3.01ms   p(90)=31.35µs  p(95)=34.37µs 
     http_req_sending...............: avg=6.59µs   min=4.14µs   med=5.64µs   max=6.02ms   p(90)=8.3µs    p(95)=9.31µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=166.95µs min=115.09µs med=156.02µs max=24.5ms   p(90)=179.96µs p(95)=190.29µs
     http_reqs......................: 114101  3803.213948/s
     iteration_duration.............: avg=258.36µs min=187.62µs med=245.98µs max=24.75ms  p(90)=277.39µs p(95)=292.84µs
     iterations.....................: 114101  3803.213948/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Contributor

@benchmarks/node-fetch results (noConsumeBody)

   ✓ active_handles.................: avg=140.049063 min=12      med=141     max=185     p(90)=163     p(95)=167    
     data_received..................: 20 MB  665 kB/s
     data_sent......................: 13 MB  431 kB/s
     http_req_blocked...............: avg=2.29µs     min=661ns   med=1.35µs  max=3.04ms  p(90)=2.08µs  p(95)=2.42µs 
     http_req_connecting............: avg=472ns      min=0s      med=0s      max=1.69ms  p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=22.91ms    min=3.29ms  med=22.21ms max=1.19s   p(90)=29.04ms p(95)=30.79ms
       { expected_response:true }...: avg=22.91ms    min=3.29ms  med=22.21ms max=1.19s   p(90)=29.04ms p(95)=30.79ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 130486
     http_req_receiving.............: avg=35.63µs    min=10.34µs med=26.12µs max=16.36ms p(90)=40.5µs  p(95)=47.78µs
     http_req_sending...............: avg=11.45µs    min=3.57µs  med=6.99µs  max=6.58ms  p(90)=10.54µs p(95)=14.89µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=22.87ms    min=3.26ms  med=22.17ms max=1.19s   p(90)=28.99ms p(95)=30.72ms
     http_reqs......................: 130486 4349.071635/s
     iteration_duration.............: avg=45.94ms    min=10.61ms med=44.34ms max=1.22s   p(90)=49.87ms p(95)=55.4ms 
     iterations.....................: 65222  2173.835892/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

@benchmarks/node-fetch results (consumeBody)

   ✓ active_handles.................: avg=140.661566 min=14      med=141     max=185     p(90)=159     p(95)=165    
     data_received..................: 20 MB  651 kB/s
     data_sent......................: 13 MB  418 kB/s
     http_req_blocked...............: avg=2.99µs     min=671ns   med=1.19µs  max=12.1ms  p(90)=1.99µs  p(95)=2.23µs 
     http_req_connecting............: avg=1.07µs     min=0s      med=0s      max=11.95ms p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=23.41ms    min=3.57ms  med=22.76ms max=1.21s   p(90)=29.35ms p(95)=30.73ms
       { expected_response:true }...: avg=23.41ms    min=3.57ms  med=22.76ms max=1.21s   p(90)=29.35ms p(95)=30.73ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 127743
     http_req_receiving.............: avg=33.79µs    min=9.44µs  med=24.71µs max=12.98ms p(90)=38.83µs p(95)=45µs   
     http_req_sending...............: avg=11.42µs    min=3.36µs  med=6.04µs  max=12.63ms p(90)=9.98µs  p(95)=13.81µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=23.36ms    min=3.51ms  med=22.72ms max=1.21s   p(90)=29.31ms p(95)=30.68ms
     http_reqs......................: 127743 4257.695217/s
     iteration_duration.............: avg=46.93ms    min=11.87ms med=45.39ms max=1.24s   p(90)=49.75ms p(95)=55.93ms
     iterations.....................: 63850  2128.13101/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

@benchmarks/server results (undici)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 219348      ✗ 0     
     data_received..................: 22 MB   735 kB/s
     data_sent......................: 8.8 MB  293 kB/s
     http_req_blocked...............: avg=1.42µs   min=921ns    med=1.21µs   max=249.38µs p(90)=1.9µs    p(95)=2.06µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=111.19µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=211.15µs min=149.23µs med=199.51µs max=55.9ms   p(90)=225.57µs p(95)=234.84µs
       { expected_response:true }...: avg=211.15µs min=149.23µs med=199.51µs max=55.9ms   p(90)=225.57µs p(95)=234.84µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 109674
     http_req_receiving.............: avg=25.21µs  min=13.65µs  med=23.64µs  max=2.25ms   p(90)=30.77µs  p(95)=33.46µs 
     http_req_sending...............: avg=6.38µs   min=4.03µs   med=5.53µs   max=292.56µs p(90)=8.21µs   p(95)=8.89µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=179.55µs min=126.16µs med=167.84µs max=55.81ms  p(90)=190.7µs  p(95)=199.34µs
     http_reqs......................: 109674  3655.632163/s
     iteration_duration.............: avg=269.12µs min=208.24µs med=256.44µs max=56.07ms  p(90)=286.13µs p(95)=297.41µs
     iterations.....................: 109674  3655.632163/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Contributor

@benchmarks/server results (ponyfill)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 297000      ✗ 0     
     data_received..................: 29 MB   975 kB/s
     data_sent......................: 12 MB   396 kB/s
     http_req_blocked...............: avg=1.41µs   min=921ns    med=1.2µs    max=212.83µs p(90)=1.87µs   p(95)=2.02µs  
     http_req_connecting............: avg=0ns      min=0s       med=0s       max=124.64µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=139.37µs min=91.22µs  med=134.91µs max=6.06ms   p(90)=157.05µs p(95)=164.36µs
       { expected_response:true }...: avg=139.37µs min=91.22µs  med=134.91µs max=6.06ms   p(90)=157.05µs p(95)=164.36µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 148500
     http_req_receiving.............: avg=24.27µs  min=12.02µs  med=22.75µs  max=4.35ms   p(90)=30.17µs  p(95)=32.99µs 
     http_req_sending...............: avg=6.26µs   min=3.98µs   med=5.37µs   max=1.3ms    p(90)=8.07µs   p(95)=8.66µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=108.83µs min=65.05µs  med=104µs    max=6ms      p(90)=122.96µs p(95)=128.87µs
     http_reqs......................: 148500  4949.828709/s
     iteration_duration.............: avg=197.52µs min=140.76µs med=192.09µs max=11.06ms  p(90)=217.93µs p(95)=227.6µs 
     iterations.....................: 148500  4949.828709/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
.changeset/@whatwg-node_server-2082-dependencies.md (1)

1-6: Clear Documentation of Dependency Updates
This changeset concisely documents the update of @whatwg-node/fetch from "^0.10.0" to "^0.10.3". The inclusion of a reference link to the updated package version is very useful.
Note: A static analysis hint (MD007) flagged unordered list indentation. Consider reviewing the markdown formatting if you aim for full compliance with style guidelines.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

5-5: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)

.changeset/@whatwg-node_fetch-2082-dependencies.md (1)

1-6: Accurate Documentation for @whatwg-node/node-fetch Update
The changeset correctly outlines the dependency update from "^0.7.8" to "^0.7.9" and includes a link for reference.
Note: Similar to the other changeset file, double-check the indentation of the unordered list items to address the MD007 warning if desired.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

5-5: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)

.changeset/@whatwg-node_server-plugin-cookies-2082-dependencies.md (2)

5-7: Markdown List Indentation

Markdownlint flagged an indentation issue (MD007) on these list items. The current lines have a two-space indent before the hyphen, whereas the expected indentation is 0 spaces. Consider removing the extra indentation to adhere to markdown styling guidelines.

-  - Updated dependency [`@whatwg-node/cookie-store@^0.2.2` ↗︎](https://www.npmjs.com/package/@whatwg-node/cookie-store/v/0.2.2) (from `0.2.2`, in `dependencies`)
-  - Added dependency [`@whatwg-node/server@^0.9.67` ↗︎](https://www.npmjs.com/package/@whatwg-node/server/v/0.9.67) (to `dependencies`)
-  - Removed dependency [`@whatwg-node/server@^0.9.44` ↗︎](https://www.npmjs.com/package/@whatwg-node/server/v/0.9.44) (from `peerDependencies`)
+ - Updated dependency [`@whatwg-node/cookie-store@^0.2.2` ↗︎](https://www.npmjs.com/package/@whatwg-node/cookie-store/v/0.2.2) (from `0.2.2`, in `dependencies`)
+ - Added dependency [`@whatwg-node/server@^0.9.67` ↗︎](https://www.npmjs.com/package/@whatwg-node/server/v/0.9.67) (to `dependencies`)
+ - Removed dependency [`@whatwg-node/server@^0.9.44` ↗︎](https://www.npmjs.com/package/@whatwg-node/server/v/0.9.44) (from `peerDependencies`)
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

5-5: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)


6-6: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)


7-7: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)


8-8: End-of-File Newline

Consider ensuring that the file ends with a newline to conform with POSIX standards and improve overall file consistency.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bb311fa and 5ae5851.

📒 Files selected for processing (6)
  • .changeset/@whatwg-node_fetch-2082-dependencies.md (1 hunks)
  • .changeset/@whatwg-node_server-2082-dependencies.md (1 hunks)
  • .changeset/@whatwg-node_server-plugin-cookies-2082-dependencies.md (1 hunks)
  • packages/fetch/package.json (1 hunks)
  • packages/server-plugin-cookies/package.json (1 hunks)
  • packages/server/package.json (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
.changeset/@whatwg-node_fetch-2082-dependencies.md

5-5: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)

.changeset/@whatwg-node_server-2082-dependencies.md

5-5: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)

.changeset/@whatwg-node_server-plugin-cookies-2082-dependencies.md

5-5: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)


6-6: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)


7-7: Unordered list indentation
Expected: 0; Actual: 2

(MD007, ul-indent)

🔇 Additional comments (6)
packages/fetch/package.json (1)

18-21: Dependency Version Update for @whatwg-node/node-fetch
The update from "^0.7.8" to "^0.7.9" is clearly reflected here. This aligns with the broader dependency update strategy in the project.

packages/server-plugin-cookies/package.json (2)

1-12: Removal of Legacy Peer Dependencies
The previous peer dependency on "@whatwg-node/server": "^0.9.44" has been removed. Please ensure that all consumers of this package are aware of this change and that there is no breakage in compatibility.


37-38: Refined Dependency Declarations
Updating "@whatwg-node/cookie-store" from a fixed version to "^0.2.2", along with adding "@whatwg-node/server": "^0.9.67", helps by allowing minor version updates and ensures alignment with the updated ecosystem.

packages/server/package.json (1)

38-38: Updated @whatwg-node/fetch Dependency
The bump from "^0.10.0" to "^0.10.3" is in line with the recent dependency revisions across the project. Please verify that this update does not introduce any unintended changes in behavior.

.changeset/@whatwg-node_server-plugin-cookies-2082-dependencies.md (2)

1-3: Header Section Validation

The header metadata is accurate and follows the changeset format for a patch update.


4-4: Dependencies Section Title

The title "dependencies updates:" clearly introduces the list of dependency modifications.

@ardatan ardatan merged commit b217e30 into master Feb 20, 2025
3 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant