-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align versions #2082
Align versions #2082
Conversation
WalkthroughThis pull request updates dependency versions across multiple packages. The dependency Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🚀 Snapshot Release (
|
Package | Version | Info |
---|---|---|
@whatwg-node/fetch |
0.10.4-alpha-20250220121345-559e23af1fee012d82a99600f796c28c8c111318 |
npm ↗︎ unpkg ↗︎ |
@whatwg-node/node-fetch |
0.7.10-alpha-20250220121345-559e23af1fee012d82a99600f796c28c8c111318 |
npm ↗︎ unpkg ↗︎ |
✅
|
✅
|
✅
|
✅
|
✅
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
.changeset/@whatwg-node_server-2082-dependencies.md (1)
1-6
: Clear Documentation of Dependency Updates
This changeset concisely documents the update of@whatwg-node/fetch
from"^0.10.0"
to"^0.10.3"
. The inclusion of a reference link to the updated package version is very useful.
Note: A static analysis hint (MD007) flagged unordered list indentation. Consider reviewing the markdown formatting if you aim for full compliance with style guidelines.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
5-5: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
.changeset/@whatwg-node_fetch-2082-dependencies.md (1)
1-6
: Accurate Documentation for @whatwg-node/node-fetch Update
The changeset correctly outlines the dependency update from"^0.7.8"
to"^0.7.9"
and includes a link for reference.
Note: Similar to the other changeset file, double-check the indentation of the unordered list items to address the MD007 warning if desired.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
5-5: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
.changeset/@whatwg-node_server-plugin-cookies-2082-dependencies.md (2)
5-7
: Markdown List IndentationMarkdownlint flagged an indentation issue (MD007) on these list items. The current lines have a two-space indent before the hyphen, whereas the expected indentation is 0 spaces. Consider removing the extra indentation to adhere to markdown styling guidelines.
- - Updated dependency [`@whatwg-node/cookie-store@^0.2.2` ↗︎](https://www.npmjs.com/package/@whatwg-node/cookie-store/v/0.2.2) (from `0.2.2`, in `dependencies`) - - Added dependency [`@whatwg-node/server@^0.9.67` ↗︎](https://www.npmjs.com/package/@whatwg-node/server/v/0.9.67) (to `dependencies`) - - Removed dependency [`@whatwg-node/server@^0.9.44` ↗︎](https://www.npmjs.com/package/@whatwg-node/server/v/0.9.44) (from `peerDependencies`) + - Updated dependency [`@whatwg-node/cookie-store@^0.2.2` ↗︎](https://www.npmjs.com/package/@whatwg-node/cookie-store/v/0.2.2) (from `0.2.2`, in `dependencies`) + - Added dependency [`@whatwg-node/server@^0.9.67` ↗︎](https://www.npmjs.com/package/@whatwg-node/server/v/0.9.67) (to `dependencies`) + - Removed dependency [`@whatwg-node/server@^0.9.44` ↗︎](https://www.npmjs.com/package/@whatwg-node/server/v/0.9.44) (from `peerDependencies`)🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
5-5: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
6-6: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
7-7: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
8-8
: End-of-File NewlineConsider ensuring that the file ends with a newline to conform with POSIX standards and improve overall file consistency.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.changeset/@whatwg-node_fetch-2082-dependencies.md
(1 hunks).changeset/@whatwg-node_server-2082-dependencies.md
(1 hunks).changeset/@whatwg-node_server-plugin-cookies-2082-dependencies.md
(1 hunks)packages/fetch/package.json
(1 hunks)packages/server-plugin-cookies/package.json
(1 hunks)packages/server/package.json
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
.changeset/@whatwg-node_fetch-2082-dependencies.md
5-5: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
.changeset/@whatwg-node_server-2082-dependencies.md
5-5: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
.changeset/@whatwg-node_server-plugin-cookies-2082-dependencies.md
5-5: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
6-6: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
7-7: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
🔇 Additional comments (6)
packages/fetch/package.json (1)
18-21
: Dependency Version Update for @whatwg-node/node-fetch
The update from"^0.7.8"
to"^0.7.9"
is clearly reflected here. This aligns with the broader dependency update strategy in the project.packages/server-plugin-cookies/package.json (2)
1-12
: Removal of Legacy Peer Dependencies
The previous peer dependency on"@whatwg-node/server": "^0.9.44"
has been removed. Please ensure that all consumers of this package are aware of this change and that there is no breakage in compatibility.
37-38
: Refined Dependency Declarations
Updating"@whatwg-node/cookie-store"
from a fixed version to"^0.2.2"
, along with adding"@whatwg-node/server": "^0.9.67"
, helps by allowing minor version updates and ensures alignment with the updated ecosystem.packages/server/package.json (1)
38-38
: Updated @whatwg-node/fetch Dependency
The bump from"^0.10.0"
to"^0.10.3"
is in line with the recent dependency revisions across the project. Please verify that this update does not introduce any unintended changes in behavior..changeset/@whatwg-node_server-plugin-cookies-2082-dependencies.md (2)
1-3
: Header Section ValidationThe header metadata is accurate and follows the changeset format for a patch update.
4-4
: Dependencies Section TitleThe title "dependencies updates:" clearly introduces the list of dependency modifications.
Related #2077
Summary by CodeRabbit