-
-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GraphQL v15 #1353
Support GraphQL v15 #1353
Conversation
kamilkisiela
commented
Apr 7, 2020
•
edited by abernix
Loading
edited by abernix
- Support GraphQL v15 apollographql/apollo-link#1263
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this!
I've manually confirmed that keeping the graphql
devDependencies
at ^14.0.0
allows tests to pass (which are failing due to type errors, not because of runtime errors). Once apollographql/apollo-link#1263 lands, bumping this to ^15.0.0
, it won't fail tests.
If you're okay with having tests failing on master
, then go ahead with merging this and adjusting later, otherwise, I'd support only landing with just the peerDependencies
bump. Either way, your call!
Worth noting that we've never published this package with yarn
before, but I don't suspect that would present any problems that might surface as a breaking change. The perfectionist in me would say that the yarn.lock
addition would probably be better compartmentalized into its own commit to preserve the sanctity of the commit history, but that's also non-blocking. (Fwiw, I happen to have a package-lock.json
locally from the last v4.0.7
publish, but just realizing now that it's .gitignore
'd so unsure if it's truly valuable in its current form.)
LGTM.
I pushed |
Now that apollographql/apollo-link#1263 is merged, we can run the tests again and see if they pass.