Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit 6d99f92 uses globby which breaks file scanning in Next.js apps #370

Closed
msheakoski opened this issue Dec 16, 2019 · 2 comments
Closed

Commit 6d99f92 uses globby which breaks file scanning in Next.js apps #370

msheakoski opened this issue Dec 16, 2019 · 2 comments
Labels
bug Something isn't working waiting for release

Comments

@msheakoski
Copy link

msheakoski commented Dec 16, 2019 •
edited
Loading

Commit 6d99f92 introduced a change where glob was switched to globby in file-scanner.ts. Because globby skips folders with symbols in it's name, scanning for gql fails when it is located inside of files containing brackets such as src/pages/[category]/[product].tsx which are used in nearly all Next.js apps for routing.

Related issue: dotansimha/graphql-code-generator#3058
@ardatan
Copy link
Owner

ardatan commented Dec 18, 2019

It is related to document loader in core not file-scanner. But you're right, this is a bug. We're currently investigating it.

@ardatan ardatan added the bug Something isn't working label Dec 30, 2019
ardatan added a commit that referenced this issue Dec 30, 2019
@ardatan
Add failing test for #370
b149b57
ardatan added a commit that referenced this issue Dec 31, 2019
@ardatan
Merge branch 'master' into reproduction-#370
d09e0de
This was referenced Dec 31, 2019
Merged
Closed
ardatan added a commit that referenced this issue Jan 1, 2020
@ardatan
Support brackets in file name (#388)
b89c4ad 
* Add failing test for #370

* Do not check if it is glob for isValidPath
@ardatan
Copy link
Owner

ardatan commented Jan 1, 2020 •
edited
Loading

Fixed in v0.8.1!

@ardatan ardatan closed this as completed Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working waiting for release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msheakoski @ardatan