Update to Support Dispatching Events with Non-Integer IDs #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it'll be necessary to rise up the NuGet package version and update it in Clean Architecture. If you like my solution, I can go ahead and implement that, then propose PR. |
|
@ardalis, need your review for this issue. Hope u will answer. |
ardalis
approved these changes
Mar 20, 2024
|
Great, thanks, @demidov-ad ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope you're doing well!
I encountered the issue described in this thread:
ardalis/CleanArchitecture#644
I wasn't quite satisfied with the solution proposed by the author, so I suggest considering this pull request. Usage can be seen in the unit tests. As you can observe, users won't face conflicts since the support will be native.
I hope you also find this solution appealing! I'd appreciate any feedback you have.