Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typography): enhanced typography styles for handling long words #2583

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

oljc
Copy link
Member

@oljc oljc commented Jul 25, 2023

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Component style change
  • Typescript definition change
  • Documentation change
  • Coding style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Breaking change
  • Others

Background and context

typography组件对连续单词、数字出现省略失效问题。
https://codesandbox.io/s/long-hooks-8r9q9j?file=/src/App.vue

Solution

How is the change tested?

默认给typography加上单词拆分overflow-wrap。overflow-wrap (感觉使用anywhere可以不破坏单词结构的情况下尽可能多地显示文本内容时还尊重语义关联。)
同时参考React版本的默认效果:Arco React版

经测试增加后不会影响以前的版本效果。
image

Changelog

Component Changelog(CN) Changelog(EN) Related issues
typography 增强对连续长单词的省略支持 enhanced typography styles for handling long words

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others
    should be submitted to main branch)

Other information

@flsion flsion added this to the 2.49.2 milestone Jul 28, 2023
@flsion flsion self-assigned this Jul 28, 2023
@flsion flsion added the 🔮 Style Something about component style label Jul 28, 2023
@flsion flsion merged commit 9d2ba37 into arco-design:main Jul 28, 2023
@oljc oljc deleted the enhance-typography branch February 2, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 Style Something about component style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants