Update XHR logs with response data when it arrives #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- always show response status code and description, in the same format as we do for cy.request - always show request duration (as reported by Cypress) - show response body if the status code is a non-successful one and we haven't already logged the response body in a cy:route log
|
Looks good. Will update readme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update XHR logs with server response data when it arrives:
This required quite a lot of changes but most of them are related to tests. We might also want to document when the XHR response body is included in the logs, but I didn't find a suitable existing place in the README, and that can also be done separately if wanted.
Resolves #61.