Loosen line endings check to ignore ontology (.xml) files #11282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiatt
approved these changes
Aug 6, 2024
|
Not sure why coverage check is indicating a decrease. Nothing in this PR should have lowered it. |
|
Probably coverage was lowered slightly on the target after latest merges to dev/7.6.x but those coverage-lowering commits were missing on this branch. I could have rebased, but not worth it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description of Change
A unix line endings check was added in 7.6 to improve collaboration and prevent checking in code files with mixed line endings. It might be a bit overkill to enforce this for data files like ontology files, however, which we noticed when upgrading Arches for Science and discussed here.