Fix memory based on PR "less event data" #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
factorized streams
boeschf
previously approved these changes
Sep 18, 2024
arbor/backends/event_stream_base.hpp
Outdated
| for (auto& lane: lanes) { | ||
| auto div = divs[cell]; | ||
| for (const auto& lane: lanes) { | ||
| const auto div = divs[cell]; |
There was a problem hiding this comment.
Suggested change
| const auto div = divs[cell]; | |
| auto div = divs[cell]; |
no need for const (not wrong but adds noise imo)
There was a problem hiding this comment.
Yeah, that was fishing for an issue that wasn't there. Agreed on the principle that const values
are mostly noise.
arbor/backends/event_stream_base.hpp
Outdated
Comment on lines
89
to
91
| const auto time = evt.time; | ||
| const auto weight = evt.weight; | ||
| const auto target = evt.target; |
There was a problem hiding this comment.
Suggested change
| const auto time = evt.time; | |
| const auto weight = evt.weight; | |
| const auto target = evt.target; | |
| auto time = evt.time; | |
| auto weight = evt.weight; | |
| auto target = evt.target; |
same here
boeschf
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.