Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typo grammar #2359

Merged
merged 2 commits into from
Aug 1, 2024
Merged

fixed typo grammar #2359

merged 2 commits into from
Aug 1, 2024

Conversation

ErbB4
Copy link
Collaborator

@ErbB4 ErbB4 commented Aug 1, 2024

No description provided.

@@ -224,14 +224,14 @@ From morphologies to points and segments

The :cpp:type:`morphology` class has the ``branch_segments`` method for
returning a vector of :cpp:type:`msegment` objects that describe the geometry
of that branch. However, determining the position in space of an
of that branch. However, determining the position in the space of an
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'the' here feels wrong, to me. We are saying
X determines the position and orientation of Y in space.
'Space' as in the abstract notion of 3D Eulerian space.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see

@thorstenhater thorstenhater merged commit 9f1dd8a into master Aug 1, 2024
3 checks passed
@thorstenhater thorstenhater deleted the ErbB4-patch-3 branch August 1, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants