-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add spike source docs. #1939
add spike source docs. #1939
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything reasonable that can be done in the code example to show "oh hey, we have 3 spike detectors, so now we have spikes with id 0-2", that'll show the input output relationship?
Yes, @brenthuisman earmarked this for himself. But the gist is, we are going to attach a metadata field to the spike callback, eg location as s-exp string and label string, so you can engage in some filtering. At least in C++ that should work, for Python performance might be an issue. Although this conflates issues, see here: #1929 |
Fixed: #1941 |
That's the core issue right there, they are both part of the data collection framework and of the networking facilities. |
=> they should be in both places. By adding a link I'll let you get away with adding text just once :) BUT, it would be confusing to have some of them in decor->placeables, and others under interconnectivity. Currently in the former there lives |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I now approve of this message.
I likewise approve your additions ... it's still funny to me that we can circumevent review process this way. |
Explain where spikes come from.
Closes #1647