Tests/multi deployment #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObiWahn
force-pushed
the
tests/multi-deployment
branch
3 times, most recently
from
0d5e171 to
2d32098
Compare
ewoutp
suggested changes
Mar 29, 2018
tests/deployments_test.go
Outdated
| if err := waitUntilArangoDeploymentHealthy(deployment2, DBClient2, k8sClient, ""); err != nil { | ||
| t.Fatalf("Deployment not healthy in time: %v", err) | ||
| } | ||
|
|
There was a problem hiding this comment.
To make sure that we can talk to individual deployments, I'll like to see an additional test here.
- Create a collection in deployment 1 (named
col1) - Create a collection in deployment 2 (named
col2) - Check that deployment 1 has a collection named
col1but notcol2 - Check that deployment 2 has a collection named
col2but notcol1
ObiWahn
force-pushed
the
tests/multi-deployment
branch
2 times, most recently
from
a45ab4c to
2b3239d
Compare
ObiWahn
force-pushed
the
tests/multi-deployment
branch
from
d31745b to
71e7e61
Compare
ewoutp
suggested changes
Apr 5, 2018
tests/deployments_test.go
Outdated
| _, err = deploymentClient.DatabaseV1alpha().ArangoDeployments(k8sNameSpace).Create(deploymentTemplate2) | ||
| assert.NoError(t, err, fmt.Sprintf("Deployment creation failed: %v", err)) | ||
|
|
||
| // Wait for deployment to be ready |
tests/deployments_test.go
Outdated
| deployment2, err := waitUntilDeployment(deploymentClient, deploymentTemplate2.GetName(), k8sNameSpace, deploymentIsReady()) | ||
| assert.NoError(t, err, fmt.Sprintf("Deployment not running in time: %v", err)) | ||
|
|
||
| // Create a database client |
tests/deployments_test.go
Outdated
| DBClient2 := mustNewArangodDatabaseClient(ctx, k8sClient, deployment2, t) | ||
| assert.NoError(t, waitUntilArangoDeploymentHealthy(deployment1, DBClient1, k8sClient, ""), fmt.Sprintf("Deployment not healthy in time: %v", err)) | ||
|
|
||
| db1, err := DBClient1.Database(ctx, "_system") |
There was a problem hiding this comment.
Add a comment here to explain what the intent of line 144 - 152 is
tests/deployments_test.go
Outdated
| _, err = db2.CreateCollection(ctx, "col2", nil) | ||
| assert.NoError(t, err, "failed to create collection") | ||
|
|
||
| collections1, err := db1.Collections(ctx) |
There was a problem hiding this comment.
This is where the "real test" starts, please add a comment explaining what is being checked
* origin/master: (43 commits) Disabled colorizing logs Persistent... Only remove namespace in cleanup phase Collecting logs in script Using panic safe resource watcher Ignore errors in `kubelet logs` Adding panic-safe ResourceWatcher Archive log files Prevent panic on duplicate Delete (storage) Prevent panic on duplicate Delete avoid ' ArangoDB operator -> ArangoDB Kubernetes Operator Follow file name conventions of main docs, move to Tutorials Fixed link Moved directory structure wrt docs Quickly fail when deployment no longer exists Renamed all enum values to title case Doc file rename Fixed build Typos ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.