Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advertised Endpoints #299

Merged
merged 11 commits into from
Dec 5, 2018
Merged

Advertised Endpoints #299

merged 11 commits into from
Dec 5, 2018

Conversation

maierlars
Copy link
Contributor

No description provided.

@maierlars maierlars self-assigned this Nov 8, 2018
@maierlars maierlars requested a review from neunhoef November 8, 2018 00:34
@ghost ghost added the 2 - Working label Nov 8, 2018
neunhoef
neunhoef approved these changes Nov 8, 2018
View reviewed changes
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the question in the comment. LGTM

neunhoef
neunhoef approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maierlars maierlars merged commit eb67490 into master Dec 5, 2018
@ghost ghost removed the 2 - Working label Dec 5, 2018
@maierlars maierlars deleted the feature/advertised-endpoints branch December 5, 2018 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neunhoef neunhoef neunhoef approved these changes

Assignees

@maierlars maierlars

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maierlars @neunhoef