Fixes needed to run on latest openshift. #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewvon
approved these changes
Jun 1, 2018
| @@ -167,6 +167,8 @@ func (ib *imagesBuilder) fetchArangoDBImageIDAndVersion(ctx context.Context, ima | |||
| args := []string{ | |||
| "--server.authentication=false", | |||
| fmt.Sprintf("--server.endpoint=tcp://[::]:%d", k8sutil.ArangoPort), | |||
There was a problem hiding this comment.
does this imply that the connection will never be ssl? and never use authentication?
There was a problem hiding this comment.
For the ID pod : Yes.
There was a problem hiding this comment.
The ID pod is run very quickly to fetch version information for a given image name.
There was a problem hiding this comment.
It will never be accessible from outside, nor will it store any data or live longer than a few seconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains fixes needed to deploy ArangoDB on OpenShift.
Tested on
minishift v1.17.0+f974f0c.Note that in order to make it work, also a patched version of the ArangoDB image is needed.
A
Dockerfileas below is known to work.These changes are patched into newly released arangodb images.