Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IdentityBadge: default labelStyle to avoid undefined css #779

Merged
merged 1 commit into from
Jun 10, 2020
Merged

IdentityBadge: default labelStyle to avoid undefined css #779

merged 1 commit into from
Jun 10, 2020

Conversation

sohkai
Copy link
Contributor

@sohkai sohkai commented Jun 10, 2020 •
edited
Loading

Oops, since we always do ${labelStyle} when passing it to the BadgeBase, it gets rendered into an undefined css class.

Screen Shot 2020-06-10 at 1 58 20 PM

@auto-assign auto-assign bot requested a review from bpierre June 10, 2020 11:58
@sohkai sohkai merged commit 51df1b1 into master Jun 10, 2020
@sohkai sohkai deleted the identity-badge-default-labelstyle branch June 10, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpierre bpierre bpierre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sohkai @bpierre