Move to yarn.lock + update dependencies #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bpierre
commented
Dec 18, 2019
bpierre
commented
- Update dependencies (fix a security alert).
- Remove WebpackMonitor (unmaintained, little benefit on the gallery).
- Replace the webpack UglifyJS plugin by the Terser plugin (the UglifyJS plugin is now unmaintained).
- Move to yarn.lock files.
- Prettier: formatting change.
Also: - Remove WebpackMonitor (unmaintained + little benefit on the gallery) - Replace the webpack UglifyJS plugin by the Terser plugin (the UglifyJS plugin has been deprecated).
sohkai
reviewed
Dec 18, 2019
package.json
Outdated
| "rollup-plugin-visualizer": "^1.1.1", | ||
| "rollup-plugin-sizes": "^1.0.1", | ||
| "rollup-plugin-uglify": "^6.0.4", | ||
| "rollup-plugin-url": "^3.0.1", |
There was a problem hiding this comment.
It looks like there are also deprecation warnings for rollup-plugin-url and rollup-plugin-node-resolve; should we update those as well?
There was a problem hiding this comment.
Oh yes I didn’t see that! I thought yarn outdated or yarn upgrade-interactive would show that, but it seems that no command shows the deprecated status of dependencies − apart from running yarn info | grep deprecated on them individually… are you doing this manually, or do you know a secret command? 😄
Edit 😆 :
alias check-deprecated-modules="cat package.json | jq '(.dependencies+.devDependencies) | keys | .[]' | xargs -I {} sh -c 'yarn info --json {} | jq \".data.name,.data.deprecated\"'"There was a problem hiding this comment.
are you doing this manually, or do you know a secret command?
I just see the warnings during install :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.