Agent: Move to buidler #1245
Agent: Move to buidler #1245
Conversation
| @@ -1,8 +1,12 @@ | |||
| pragma solidity 0.4.24; | |||
|
|
|||
| import "@aragon/os/contracts/acl/ACL.sol"; | |||
| import "@aragon/os/contracts/apm/APMRegistry.sol"; | |||
There was a problem hiding this comment.
The new imports are needed to deploy the Aragon bases on the local ganache chain we ran with the buidler plugin.
apps/agent/scripts/ganache-cli.sh
Outdated
| @@ -0,0 +1,80 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
This file will live on @aragon/contract-helpers-test. I include it locally until we publish the new version.
There was a problem hiding this comment.
Hey @0xGabi, I must've miscommunicated a bit when discussing this migration!
Let me know what your thoughts are on my comments below!
Note I also start using yarn as default. Let me know what you think and if I may rollback the change.
Yes, this should be the case already! This repo now uses yarn workspaces!
Migrate solium rules to use solhint
We can do this in a second step :)
Decide about the rule we have on the node engine (currently we are fixed to node 10) with the migration to buidler I think we can safely move to node 12.
Agreed, I pinned it to node 10 because it still relied on [email protected].
apps/agent/buidler.config.js
Outdated
| const { usePlugin } = require('@nomiclabs/buidler/config') | ||
| const hooks = require('./scripts/buidler-hooks') | ||
|
|
||
| usePlugin('@aragon/buidler-aragon') |
There was a problem hiding this comment.
Rather than use the buidler-aragon plugin, I was wondering if we shouldn't move to a vanilla buidler set up for now? That way we might be able to use buidlerevm or other defaults rather than configure our own ganache chain / etc.
I'm not particularly concerned at the moment about providing a good frontend developer experience for others in these apps.
There was a problem hiding this comment.
As discussed offline, this is a good step forward.
|
I'll merge with the main buidler branch where I will aggregate the rest of the apps changes. |
Replace #1092
This PR applies the changes to move the Agent app to use buidler as a developer tool and the Aragon Buidler plugin.
Changes are straight forward now that tests were migrated to truffle5. Once we get one of the apps merged I can move fast and replicate the same for the rest as is a mechanical process.
Note I also start using
yarnas default. Let me know what you think and if I may rollback the change.A few open questions we can address on following PRs are:
soliumrules to usesolhint