Fix build issue where Debug not implemented on syn::Type.
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build fails since syn::Type only adds an impl for Debug when "extra-traits" feature is enabled. This exposes a feature on typescript-definitions-derive to control whether or not syn's feature is active, and adds a cfg_attr to the derive on `Attrs`. - <dtolnay/syn#583 (comment)>
|
Any idea when this will be merged and released? |
|
@ufoscout maintainer may not be in a rush to merge anything. There's an open PR from April which doesn't seem to have gotten any attention. I'm not planning on publishing my fork to crates.io, but I will surely leave it up on github for as long as the problem is unaddressed (should you want to depend on it directly). |
|
@onelson |
|
would be really nice if this was merged, using @ufoscout branch. Really hoping this doesn't die. Using rust on a web api backend and having to manually write the definitions. |
|
@arabidopsis please merge and release this |
|
Bump. Is this crate abandoned? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build fails since
syn::Typeonly adds an impl for Debug when"extra-traits" feature is enabled. This exposes a feature on
typescript-definitions-derive to control whether or not syn's feature is
active, and adds a
cfg_attrto the derive forAttrs.This was mentioned incidentally in #4 but does not solve the breakage starting in
nightly-2019-11-25which seems to be related to the pest usage.