feat(image): save layers metadata into report #8394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
DmitriyLewen
changed the title
knqyf263
reviewed
Feb 18, 2025
pkg/scanner/scan.go
Outdated
| @@ -140,7 +141,7 @@ type Scanner struct { | |||
| // Driver defines operations of scanner | |||
| type Driver interface { | |||
| Scan(ctx context.Context, target, artifactKey string, blobKeys []string, options types.ScanOptions) ( | |||
| results types.Results, osFound ftypes.OS, err error) | |||
| results types.Results, osFound ftypes.OS, layersMetadata ftypes.LayersMetadata, err error) | |||
There was a problem hiding this comment.
What if returning a new struct like ScanReponse or types.Report? IIUC, it will not break compatibility unless we change the protobuf interfaces.
There was a problem hiding this comment.
added scanResponse - 945ddc3
pkg/types/report.go
Outdated
| RepoTags []string `json:",omitempty"` | ||
| RepoDigests []string `json:",omitempty"` | ||
| ImageConfig v1.ConfigFile `json:",omitempty"` | ||
| LayersMetadata ftypes.LayersMetadata `json:",omitempty"` |
There was a problem hiding this comment.
It belongs to Metadata. Layers is descriptive enough for me.
Suggested change
| LayersMetadata ftypes.LayersMetadata `json:",omitempty"` | |
| Layers ftypes.LayersMetadata `json:",omitempty"` |
There was a problem hiding this comment.
updated in fb65b08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We added
--max-image-sizeflag.But we decided to go further and provide users with information about the image layers.
Changes:
Related PRs
Checklist