Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(terraform): export module path on terraform modules #8374

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

Emyrk
Copy link
Contributor

@Emyrk Emyrk commented Feb 7, 2025

Description

Module path is required to distinguish between 2 modules loaded from the same root. Without the accessor, is difficult to know which module is which when iterating through the type Modules. There is value in exporting this.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Module path is required to distinguish between 2 modules loaded
from the same root.
@Emyrk Emyrk force-pushed the expose_module_path branch from aa1579e to 5d29dd2 Compare February 7, 2025 18:21
When working a block, exprorting this easily allows for determine
if in a submodule. Before this, `ModuleKey` and `InModule` must
be used. `ModuleKey` given it is a string is less precise.
Copy link
Contributor

@nikpivkin nikpivkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simar7 simar7 added this pull request to the merge queue Feb 11, 2025
Merged via the queue into aquasecurity:main with commit f9c5043 Feb 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants