Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add pre-commit hook to community tools #3203

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

mxab
Copy link
Contributor

@mxab mxab commented Nov 19, 2022

Description

Mention trivy pre-commit hook https://github.com/mxab/pre-commit-trivy

Related issues

Related PRs

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@mxab mxab mentioned this pull request Nov 19, 2022
6 tasks
@knqyf263
Copy link
Collaborator

@mxab Could you resolve the conflict?

@mxab mxab force-pushed the wip/pre-commit-hook-community branch from 5fc64cd to f64ff75 Compare November 20, 2022 07:30
@mxab
Copy link
Contributor Author

mxab commented Nov 20, 2022

ok moved it under the ide section now

By the way do you have any opionions on the pre-commit hook?
Since I run it via docker now, I cannot use the default cache dir, therefore creating a cache directory in the repo it self via .. fs --cache-dir /src/.pre-commit-trivv-cache

@knqyf263
Copy link
Collaborator

knqyf263 commented Nov 29, 2022

Since I run it via docker now, I cannot use the default cache dir, therefore creating a cache directory in the repo it self via .. fs --cache-dir /src/.pre-commit-trivv-cache

Does pre-commit automatically mount the repository directory under /src? If it is the case, your approach --cache-dir /src/.pre-commit-trivy-cache sounds good. It is better to share the same cache directory across projects though.

@mxab
Copy link
Contributor Author

mxab commented Nov 29, 2022

ok good to know, I look if I can get pre-commit to created a named volume

Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me anyway. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants