feat: add LicenseComment field

aquasecurity · Dec 12, 2024 · 041ab21 · 041ab21
1 parent f851f9b
commit 041ab21
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/pkg/sbom/spdx/marshal.go b/pkg/sbom/spdx/marshal.go
@@ -452,6 +452,7 @@ func (m *Marshaler) newOtherLicense(license string, text bool) *spdx.OtherLicens
 	}
 	if text {
 		otherLicense.ExtractedText = license
+		otherLicense.LicenseComment = "The license text represents text found in package metadata and may not represent the full text of the license"
 	} else {
 		otherLicense.LicenseName = license
 	}

diff --git a/pkg/sbom/spdx/marshal_private_test.go b/pkg/sbom/spdx/marshal_private_test.go
@@ -96,17 +96,18 @@ func TestMarshaler_normalizeLicenses(t *testing.T) {
 				"AFL 2.0",
 				"unknown-license",
 			},
-			wantLicenseName: "LicenseRef-c5e3a1aeaab71db AND AFL-2.0 AND LicenseRef-8960e1168859663e",
+			wantLicenseName: "LicenseRef-ffca10435cadded4 AND AFL-2.0 AND LicenseRef-8960e1168859663e",
 			wantOtherLicenses: []*spdx.OtherLicense{
 				{
 					LicenseIdentifier: "LicenseRef-8960e1168859663e",
 					LicenseName:       "unknown-license",
 					ExtractedText:     "NOASSERTION",
 				},
 				{
-					LicenseIdentifier: "LicenseRef-c5e3a1aeaab71db",
+					LicenseIdentifier: "LicenseRef-ffca10435cadded4",
 					LicenseName:       "NOASSERTION",
 					ExtractedText:     "unknown-license",
+					LicenseComment:    "The license text represents text found in package metadata and may not represent the full text of the license",
 				},
 			},
 		},

diff --git a/pkg/sbom/spdx/marshal_test.go b/pkg/sbom/spdx/marshal_test.go
@@ -963,11 +963,13 @@ func TestMarshaler_Marshal(t *testing.T) {
 						LicenseIdentifier: "LicenseRef-14b1606fb243e2b6",
 						LicenseName:       "NOASSERTION",
 						ExtractedText:     "BSD-4-clause",
+						LicenseComment:    "The license text represents text found in package metadata and may not represent the full text of the license",
 					},
 					{
 						LicenseIdentifier: "LicenseRef-229659393343e160",
 						LicenseName:       "NOASSERTION",
 						ExtractedText:     "UNKNOWN",
+						LicenseComment:    "The license text represents text found in package metadata and may not represent the full text of the license",
 					},
 					{
 						LicenseIdentifier: "LicenseRef-73d50f1d1ecbdb3b",