Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get end version from api #16046

Merged
merged 1 commit into from
Mar 4, 2025
Merged

get end version from api #16046

merged 1 commit into from
Mar 4, 2025

Conversation

msmouse
Copy link
Contributor

@msmouse msmouse commented Mar 4, 2025

Description

replay-verify end versions are currently manually set in gcs and we are not actually updating it.
This makes the scheduler get it from our fullnode rest api.

How Has This Been Tested?

manual run
https://github.com/aptos-labs/aptos-core/actions/runs/13662325606/job/38196109893

Key Areas to Review

Type of Change

  • New feature

Which Components or Systems Does This Change Impact?

  • Developer Infrastructure -- replay-verify

Copy link

trunk-io bot commented Mar 4, 2025

@msmouse msmouse force-pushed the 250304-alden-get-end branch from 27e3f05 to ab17e9b Compare March 4, 2025 20:25
@msmouse msmouse marked this pull request as ready for review March 4, 2025 21:46
@perryjrandall perryjrandall enabled auto-merge (rebase) March 4, 2025 22:07

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Mar 4, 2025

✅ Forge suite realistic_env_max_load success on e381349df5d54638d8f0748990047efad86189a8

two traffics test: inner traffic : committed: 12288.29 txn/s, latency: 3237.92 ms, (p50: 3000 ms, p70: 3600, p90: 5100 ms, p99: 8400 ms), latency samples: 4672320
two traffics test : committed: 99.99 txn/s, latency: 3351.30 ms, (p50: 2900 ms, p70: 3700, p90: 5700 ms, p99: 8800 ms), latency samples: 1800
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.217, avg: 0.390", "ConsensusProposalToOrdered: max: 0.312, avg: 0.304", "ConsensusOrderedToCommit: max: 0.909, avg: 0.461", "ConsensusProposalToCommit: max: 1.221, avg: 0.765"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.44s no progress at version 75540 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.88s no progress at version 2618089 (avg 0.88s) [limit 16].
Test Ok

Copy link
Contributor

github-actions bot commented Mar 4, 2025

✅ Forge suite compat success on c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> e381349df5d54638d8f0748990047efad86189a8

Compatibility test results for c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> e381349df5d54638d8f0748990047efad86189a8 (PR)
1. Check liveness of validators at old version: c5eef1450476a6f7eee96d0d1953b65df04fdb91
compatibility::simple-validator-upgrade::liveness-check : committed: 6008.30 txn/s, submitted: 6008.55 txn/s, expired: 0.25 txn/s, latency: 2823.26 ms, (p50: 2800 ms, p70: 3000, p90: 3600 ms, p99: 4500 ms), latency samples: 390184
2. Upgrading first Validator to new version: e381349df5d54638d8f0748990047efad86189a8
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 2902.71 txn/s, latency: 10035.45 ms, (p50: 10800 ms, p70: 12200, p90: 12800 ms, p99: 12900 ms), latency samples: 65660
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 2930.02 txn/s, latency: 11357.85 ms, (p50: 12700 ms, p70: 13400, p90: 13500 ms, p99: 13500 ms), latency samples: 110880
3. Upgrading rest of first batch to new version: e381349df5d54638d8f0748990047efad86189a8
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 2516.45 txn/s, latency: 11633.15 ms, (p50: 13600 ms, p70: 14300, p90: 14500 ms, p99: 14700 ms), latency samples: 54740
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 2483.60 txn/s, latency: 13458.57 ms, (p50: 14900 ms, p70: 15400, p90: 15400 ms, p99: 15800 ms), latency samples: 94560
4. upgrading second batch to new version: e381349df5d54638d8f0748990047efad86189a8
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 1765.97 txn/s, submitted: 1766.14 txn/s, expired: 0.17 txn/s, latency: 5354.51 ms, (p50: 6200 ms, p70: 6600, p90: 6900 ms, p99: 7000 ms), latency samples: 113789
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3029.45 txn/s, submitted: 3029.63 txn/s, expired: 0.18 txn/s, latency: 6293.17 ms, (p50: 6900 ms, p70: 7000, p90: 7300 ms, p99: 7400 ms), latency samples: 186829
5. check swarm health
Compatibility test for c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> e381349df5d54638d8f0748990047efad86189a8 passed
Test Ok

Copy link
Contributor

github-actions bot commented Mar 4, 2025

✅ Forge suite framework_upgrade success on c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> e381349df5d54638d8f0748990047efad86189a8

Compatibility test results for c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> e381349df5d54638d8f0748990047efad86189a8 (PR)
Upgrade the nodes to version: e381349df5d54638d8f0748990047efad86189a8
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1543.29 txn/s, submitted: 1549.47 txn/s, failed submission: 6.19 txn/s, expired: 6.19 txn/s, latency: 2460.90 ms, (p50: 1600 ms, p70: 2000, p90: 2900 ms, p99: 13300 ms), latency samples: 134700
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1716.39 txn/s, submitted: 1721.92 txn/s, failed submission: 5.53 txn/s, expired: 5.53 txn/s, latency: 1719.41 ms, (p50: 1500 ms, p70: 1800, p90: 2500 ms, p99: 3600 ms), latency samples: 155222
5. check swarm health
Compatibility test for c5eef1450476a6f7eee96d0d1953b65df04fdb91 ==> e381349df5d54638d8f0748990047efad86189a8 passed
Upgrade the remaining nodes to version: e381349df5d54638d8f0748990047efad86189a8
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1632.52 txn/s, submitted: 1636.99 txn/s, failed submission: 4.47 txn/s, expired: 4.47 txn/s, latency: 2376.77 ms, (p50: 1500 ms, p70: 2000, p90: 3300 ms, p99: 12000 ms), latency samples: 146041
Test Ok

@perryjrandall perryjrandall merged commit 436f6ab into main Mar 4, 2025
90 of 91 checks passed
@perryjrandall perryjrandall deleted the 250304-alden-get-end branch March 4, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants