Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick: limits & gas for dependencies #12166

Merged
merged 4 commits into from
Mar 5, 2024

[loader] Test gas charging logic for transitive deps

bc7cd44
Select commit
Loading
Failed to load commit list.
Merged

Cherry-pick: limits & gas for dependencies #12166

[loader] Test gas charging logic for transitive deps
bc7cd44
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 5, 2024 in 0s

63.9% (-0.2%) compared to a7a474f

View this Pull Request on Codecov

63.9% (-0.2%) compared to a7a474f

Details

Codecov Report

Attention: Patch coverage is 27.94830% with 446 lines in your changes are missing coverage. Please review.

Project coverage is 63.9%. Comparing base (a7a474f) to head (bc7cd44).
Report is 2 commits behind head on main.

Files Patch % Lines
aptos-move/aptos-vm/src/aptos_vm.rs 0.0% 124 Missing ⚠️
third_party/move/move-vm/runtime/src/loader/mod.rs 27.3% 101 Missing ⚠️
third_party/move/move-vm/runtime/src/session.rs 5.2% 72 Missing ⚠️
third_party/move/move-binary-format/src/access.rs 0.0% 30 Missing ⚠️
aptos-move/aptos-gas-meter/src/meter.rs 0.0% 20 Missing ⚠️
...aptos-gas-schedule/src/gas_schedule/transaction.rs 0.0% 20 Missing ⚠️
...party/move/move-vm/runtime/src/module_traversal.rs 0.0% 18 Missing ⚠️
aptos-move/aptos-gas-meter/src/algebra.rs 0.0% 16 Missing ⚠️
...d_party/move/move-vm/runtime/src/loader/modules.rs 44.4% 10 Missing ⚠️
..._party/move/move-vm/test-utils/src/gas_schedule.rs 0.0% 9 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff            @@
##             main   #12166     +/-   ##
=========================================
- Coverage    64.1%    63.9%   -0.2%     
=========================================
  Files         798      799      +1     
  Lines      177110   177623    +513     
=========================================
+ Hits       113534   113628     +94     
- Misses      63576    63995    +419

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov