Fix iss-related bug in Groth16 path & refactor
#12017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinush
force-pushed
the
alin/authenticator-fixes
branch
4 times, most recently
from
bc49d15 to
b1e8caf
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #12017 +/- ##
===========================================
+ Coverage 69.9% 71.4% +1.4%
===========================================
Files 2222 809 -1413
Lines 419683 184616 -235067
===========================================
- Hits 293473 131838 -161635
+ Misses 126210 52778 -73432 ☔ View full report in Codecov by Sentry. |
alinush
force-pushed
the
alin/authenticator-fixes
branch
9 times, most recently
from
931f3f4 to
beb8ccd
Compare
alinush
changed the title
iss-related bug in Groth16 pathiss-related bug in Groth16 path & refactor
alinush
force-pushed
the
alin/authenticator-fixes
branch
from
beb8ccd to
98ccbd4
Compare
alinush
requested review from
davidiw,
movekevin,
wrwg,
zekun000,
vgao1996 and
georgemitenkov
as code owners
zjma
reviewed
Feb 18, 2024
zjma
reviewed
Feb 18, 2024
zjma
reviewed
Feb 18, 2024
alinush
commented
Feb 19, 2024
alinush
commented
Feb 19, 2024
alinush
force-pushed
the
alin/authenticator-fixes
branch
from
e4967d9 to
f6e04f1
Compare
zjma
reviewed
Feb 19, 2024
| const STRUCT_NAME: &'static IdentStr = ident_str!("Groth16VerificationKey"); | ||
| } | ||
|
|
||
| impl TryFrom<Groth16VerificationKey> for PreparedVerifyingKey<Bn254> { |
There was a problem hiding this comment.
nit: worth having some UTs for all the impl TryFrom across the PR.
If they are already covered by some smoke tests, then it's fine.
There was a problem hiding this comment.
Worth having a lot more tests! Next PR!
zjma
approved these changes
Feb 19, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
heliuchuan
approved these changes
Feb 19, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
zjma
added a commit
that referenced
this pull request
Feb 22, 2024
* Fix `iss`-related bug in Groth16 path & refactor (#12017) Co-authored-by: Oliver <[email protected]> * [aptosvm] Simplify VM flows (#11888) * Duplicated logic for creating the gas meter for view functions has been removed. * Duplicated logic for calculating gas used for view functions has been removed. * There was unreachable code in failure transaction cleanup, where the discarded status has been returned immediately, but then re-checked again. The first check is shifted inside. * No more default transaction metadata. * Scripts are now validated consistently. * Simplifies transaction execution function signature to avoid `Option<String>`. * Removes duplicated features from `AptosVM` and keeps them in `MoveVMExt`. * Fixes a bug when script hash was not computed for `RunOnAbort`. Related tests are moved to `move-e2e-tests`. * [Compiler V2] Critical edge elimination (#11894) Implement a pass to eliminate critical edges by splitting them with empty blocks * [consensus configs] reduce sending block size from 2500 to 1900 (#12091) ### Description The block output limit is no longer hit with p2p txns. ### Test Plan Forge `realistic_env_max_load` TPS improves. * [Indexer-grpc] Add profiling support. (#12034) * Minor aggregator cleanup (#12013) * Minor aggregator cleanup * Addressing PR comments * [move] rotate_authentication_key_call should not modify OriginatingAddress (#12108) Co-authored-by: Alin Tomescu <[email protected]> * [Data Streaming Service] Add dynamic prefetching support * [Data Streaming Service] Add dynamic prefetching unit tests. * [Data Streaming Service] Update existing integration tests. * [State Sync] Add backpressure to fast sync receiver. * Update perf baseline for gas charging coverage improvements (reducing throughput) (#12124) * Reduce latency of cloning network sender using Arc pointers (#12103) * Avoid cloning network sender using Arc pointers * Removing a clone * 100 node sweep test * Removing a few clone operations * reset forge test * Removing some clones * Removing clones * adopt AIP-61 terminology for consistency (#12123) adopt AIP-61 terminology for consistency * [Consensus] Remove non-decoupled execution and refactor for cleaner interfaces (#12104) * fix jwk key logging (#12090) * remove spurious error lines (#12137) * randomness #1: types update from randomnet (#12106) * types update from randomnet * update * lint * lint * All validators broadcast commit vote messages (#12059) * All validators broadcast commit messages * Forge testing * Increase timeout for forge * test forge realistic_env_workload_sweep_test * run realistic_env_workload_sweep_test * run realistic_env_workload_sweep_test * run sweep test * increase forge runner duration * forge testing * Letting the proposer also broadcast commit decision for backward compatibility * removing forge changes * Added a TODO * [vm] Resource access control: runtime engine (#10544) * [vm] Resource access control: runtime engine Implements the runtime engine for resource access control: - a representation of access control specifiers in `loaded_data::runtime_access_specifiers`. - a loader for access specifiers in `runtime::loader::access_specifier_loader`. - a new stateful object representing the access control logic in `runtime::access_control`. - finally the use of the `AccessControlState` in `runtime::interpreter`. * Addressing reviewer comments. * Addressing reviewer comments. * typo: PTLA -> PTAL * Rebasing: adjusting to upstream changes * Rebasing * ObjectCodeDeployment API cleanup update (#12133) * ObjectCodeDeployment API cleanup update (#12141) * [Compiler-v2] porting more V1 unit tests to V2 (#12085) * update tests * fix bug * fix-12116 * fix missing space * add expected got * remove live-var tests * fix had_erros * fix * Enable the max object nesting check (#12129) * Resolved the warning for unused variable (#12157) * update * update * update * update * update * update * update * update * update * update * update * update * update * Squashed commit of the following: commit a50ffec Author: Zhoujun Ma <[email protected]> Date: Thu Feb 22 21:10:12 2024 +0000 lint commit 388350f Author: zhoujun.ma <[email protected]> Date: Thu Feb 22 13:04:28 2024 -0800 update commit 76f7eca Author: zhoujun.ma <[email protected]> Date: Thu Feb 22 12:56:04 2024 -0800 update commit a663542 Author: zhoujun.ma <[email protected]> Date: Thu Feb 22 12:54:18 2024 -0800 update commit b439449 Author: zhoujun.ma <[email protected]> Date: Thu Feb 22 12:34:14 2024 -0800 update commit 3378ceb Author: zhoujun.ma <[email protected]> Date: Thu Feb 22 12:17:06 2024 -0800 update commit 6cd6685 Author: zhoujun.ma <[email protected]> Date: Thu Feb 22 12:15:05 2024 -0800 update commit 6d89f37 Author: zhoujun.ma <[email protected]> Date: Thu Feb 22 12:13:51 2024 -0800 update commit 980f257 Author: zhoujun.ma <[email protected]> Date: Thu Feb 22 12:12:04 2024 -0800 update commit 16e9349 Author: Zhoujun Ma <[email protected]> Date: Thu Feb 22 18:25:08 2024 +0000 lint --------- Co-authored-by: Alin Tomescu <[email protected]> Co-authored-by: Oliver <[email protected]> Co-authored-by: George Mitenkov <[email protected]> Co-authored-by: Zekun Wang <[email protected]> Co-authored-by: Brian (Sunghoon) Cho <[email protected]> Co-authored-by: Guoteng Rao <[email protected]> Co-authored-by: Satya Vusirikala <[email protected]> Co-authored-by: David Wolinsky <[email protected]> Co-authored-by: Josh Lind <[email protected]> Co-authored-by: igor-aptos <[email protected]> Co-authored-by: Sital Kedia <[email protected]> Co-authored-by: Wolfgang Grieskamp <[email protected]> Co-authored-by: Teng Zhang <[email protected]> Co-authored-by: Junkil Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
iss, not the full field.types/src/zkid.rsinto multiple files intypes/src/zkid/