-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch the zkID Groth16 VK from on-chain #11895
Conversation
8074647
to
d3f96f0
Compare
2af01b6
to
fd99a67
Compare
fd99a67
to
6a7d2cb
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11895 +/- ##
===========================================
+ Coverage 69.8% 71.2% +1.3%
===========================================
Files 2199 796 -1403
Lines 416774 183369 -233405
===========================================
- Hits 291116 130613 -160503
+ Misses 125658 52756 -72902 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
Co-authored-by: Oliver <[email protected]>
Description
Currently, the VK was hardcoded in Rust (see #11772), but it needs to be upgradeable via on-chain governance in Move in case of bugfixes or other issues.
Note: You can run
./scripts/authenticator_regenerate.sh
to regenerate all API files and protobuf files (and other dependencies when modifying the Rust authenticator code). Otherwise, you'll get CI/CD failures.