Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

Add settings profile, admin and ssh key pages #68

Merged
merged 1 commit into from
Jan 30, 2015

Conversation

bantic
Copy link
Contributor

@bantic bantic commented Jan 17, 2015

The ajax is not yet wired up for editing name, password,
email or adding ssh keys.

refs #51 #66

The pages are now working for displaying data. The link to settings is obscured by the navbar (#67) but you can go directly to /settings to see the pages.

Notes for wiring up the data are in a separate issue.

This PR makes the pages look like:

fdiu2tp6fj

@sandersonet for you cc @mixonic

@bantic
Copy link
Contributor Author

bantic commented Jan 26, 2015

Still to do:

  • DRY ssh tests
  • allow user to delete ssh key
  • better styling for ssh adding, form, errors
  • test that create SSH key posts to /users/:user_id/ssh_keys (Due to a bug with the interaction between unit test isolated containers and Ember Data, this is much harder than expected. The URL interactions are implicitly exercised by the acceptance tests, and that will have to be enough for now, but I will revisit this later)

bantic added a commit to bantic/diesel.aptible.com that referenced this pull request Jan 27, 2015
@bantic
Copy link
Contributor Author

bantic commented Jan 27, 2015

Still to do:

  • change password
  • change email
  • change name

@bantic
Copy link
Contributor Author

bantic commented Jan 27, 2015

This is ready to go now.
The user can add/delete SSH keys and change name, email and password.
@mixonic ready for your review.
This depends on changes to auth that are in https://github.com/aptible/auth.aptible.com/pull/109.

Some screencasts:

  • change name:
    68xhpkqxhm
  • change email:
    email
  • add/delete SSH key
    sshkey

@bantic bantic assigned bantic and mixonic and unassigned bantic Jan 27, 2015
@bantic
Copy link
Contributor Author

bantic commented Jan 28, 2015

The dependent PR in auth has been merged, so this PR is no longer blocked on anything.

}

return this.ajax(url, "DELETE");
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet. I will take this and maybe push it up into application or auth adapter if I can get the logic right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that maybe buildURLWithPrefix could take a map of verbs -> prefixes, so it would be, like: buildURLWithPrefix({'POST': {'users': 'user.id'}});. Not sure how difficult that would be but it probably makes some sense, since the paths are definitely verb-dependent. I am pretty sure the GET for ssh_keys is also non-prefixed (like the DELETE).

@bantic bantic force-pushed the user-settings branch 2 times, most recently from b57d748 to c1d5792 Compare January 28, 2015 21:34
@bantic
Copy link
Contributor Author

bantic commented Jan 28, 2015

@mixonic all set now

  * User can add/delete ssh keys (/settings/ssh)
  * User can change password, email (/settings/admin)
  * User can change name (/settings/profile)
  * Styles match dashboard
  * Customized ssh-key adapter's buildURL for DELETEs
  * pin ember-data-hal-adapter to 0.1.3 (0.1.4 is broken)
  * Use model hook instead of session.currentUser in settings pages

fixes aptible#66 fixes aptible#69
@mixonic
Copy link
Contributor

mixonic commented Jan 30, 2015

I've rebased this and force pushed it to your branch @bantic. Will merge when the tests go green

mixonic added a commit that referenced this pull request Jan 30, 2015
Add settings profile, admin and ssh key pages
@mixonic mixonic merged commit 6d95c3f into aptible:master Jan 30, 2015
@mixonic mixonic deleted the user-settings branch January 30, 2015 03:18
skylar-anderson pushed a commit to skylar-anderson/dashboard.aptible.com that referenced this pull request Aug 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants