-
Notifications
You must be signed in to change notification settings - Fork 35
Add settings profile, admin and ssh key pages #68
Conversation
Still to do:
|
Still to do:
|
This is ready to go now. Some screencasts: |
The dependent PR in auth has been merged, so this PR is no longer blocked on anything. |
} | ||
|
||
return this.ajax(url, "DELETE"); | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet. I will take this and maybe push it up into application or auth adapter if I can get the logic right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking that maybe buildURLWithPrefix
could take a map of verbs -> prefixes, so it would be, like: buildURLWithPrefix({'POST': {'users': 'user.id'}});
. Not sure how difficult that would be but it probably makes some sense, since the paths are definitely verb-dependent. I am pretty sure the GET for ssh_keys is also non-prefixed (like the DELETE).
b57d748
to
c1d5792
Compare
@mixonic all set now |
* User can add/delete ssh keys (/settings/ssh) * User can change password, email (/settings/admin) * User can change name (/settings/profile) * Styles match dashboard * Customized ssh-key adapter's buildURL for DELETEs * pin ember-data-hal-adapter to 0.1.3 (0.1.4 is broken) * Use model hook instead of session.currentUser in settings pages fixes aptible#66 fixes aptible#69
c1d5792
to
c2f862b
Compare
I've rebased this and force pushed it to your branch @bantic. Will merge when the tests go green |
Add settings profile, admin and ssh key pages
The ajax is not yet wired up for editing name, password,
email or adding ssh keys.
refs #51 #66
The pages are now working for displaying data. The link to settings is obscured by the navbar (#67) but you can go directly to
/settings
to see the pages.Notes for wiring up the data are in a separate issue.
This PR makes the pages look like:
@sandersonet for you cc @mixonic