This repository has been archived by the owner on Oct 18, 2023. It is now read-only.
docker files added #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
2 tasks
stnguyen90
suggested changes
Oct 24, 2022
There was a problem hiding this comment.
I'm getting this error trying to run the container:
$ docker compose up
[+] Running 1/0
⠿ Container appwrite-hacktoberfest-react-app-1 Created 0.0s
Attaching to appwrite-hacktoberfest-react-app-1
appwrite-hacktoberfest-react-app-1 |
appwrite-hacktoberfest-react-app-1 | > [email protected] dev
appwrite-hacktoberfest-react-app-1 | > concurrently "npm run dev:only" "npm run tailwind:watch"
appwrite-hacktoberfest-react-app-1 |
appwrite-hacktoberfest-react-app-1 | [1]
appwrite-hacktoberfest-react-app-1 | [1] > [email protected] tailwind:watch
appwrite-hacktoberfest-react-app-1 | [1] > cross-env TAILWIND_MODE=watch cross-env NODE_ENV=development postcss src/styles/tailwind.css -o src/styles/tailwind-output.css -w
appwrite-hacktoberfest-react-app-1 | [1]
appwrite-hacktoberfest-react-app-1 | [0]
appwrite-hacktoberfest-react-app-1 | [0] > [email protected] dev:only
appwrite-hacktoberfest-react-app-1 | [0] > svelte-kit dev
appwrite-hacktoberfest-react-app-1 | [0]
appwrite-hacktoberfest-react-app-1 | [0] > spawn Unknown system error -8
appwrite-hacktoberfest-react-app-1 | [0] Error: spawn Unknown system error -8
appwrite-hacktoberfest-react-app-1 | [0] at ChildProcess.spawn (node:internal/child_process:413:11)
appwrite-hacktoberfest-react-app-1 | [0] at Object.spawn (node:child_process:743:9)
appwrite-hacktoberfest-react-app-1 | [0] at ensureServiceIsRunning (/app/node_modules/esbuild/lib/main.js:1766:29)
appwrite-hacktoberfest-react-app-1 | [0] at Object.build (/app/node_modules/esbuild/lib/main.js:1658:26)
appwrite-hacktoberfest-react-app-1 | [0] at /app/node_modules/vite/dist/node/chunks/dep-63d4bd14.js:50441:54
appwrite-hacktoberfest-react-app-1 | [0] at Array.map (<anonymous>)
appwrite-hacktoberfest-react-app-1 | [0] at scanImports (/app/node_modules/vite/dist/node/chunks/dep-63d4bd14.js:50441:31)
appwrite-hacktoberfest-react-app-1 | [0] at async optimizeDeps (/app/node_modules/vite/dist/node/chunks/dep-63d4bd14.js:71611:30)
appwrite-hacktoberfest-react-app-1 | [0] at async runOptimize (/app/node_modules/vite/dist/node/chunks/dep-63d4bd14.js:75473:48)
appwrite-hacktoberfest-react-app-1 | [0] at async Object.createServer (/app/node_modules/vite/dist/node/chunks/dep-63d4bd14.js:75502:9)
appwrite-hacktoberfest-react-app-1 | [0] file:///app/node_modules/@sveltejs/kit/dist/chunks/index.js:3355
appwrite-hacktoberfest-react-app-1 | [0] throw new Error('Cannot close server before it is initialized');
| build: | ||
| context: ./ | ||
| dockerfile: Dockerfile | ||
| image: app-write |
There was a problem hiding this comment.
appwrite is spelled wrong.
| context: ./ | ||
| dockerfile: Dockerfile | ||
| image: app-write | ||
| stdin_open: true |
Comment on lines
+18
to
+20
| networks: | ||
| app: | ||
| driver: bridge |
There was a problem hiding this comment.
Shouldn't this be the default? Why do we need to add this?
| @@ -0,0 +1,20 @@ | |||
| version: '3' | |||
| services: | |||
| react-app: | |||
|
|
||
| COPY . . | ||
|
|
||
| CMD ["npm","run","dev","-- --open"] |
There was a problem hiding this comment.
why is the --open option needed?
| # if facing error while building image, paste there two command in terminal. | ||
|
|
||
| # export DOCKER_BUILDKIT=0 | ||
| #export COMPOSE_DOCKER_CLI_BUILD=0 |
There was a problem hiding this comment.
it's important to be consistent:
Suggested change
| #export COMPOSE_DOCKER_CLI_BUILD=0 | |
| # export COMPOSE_DOCKER_CLI_BUILD=0 |
| - app | ||
| volumes: | ||
| - ./src:/app/src | ||
| - ./app/node_modules |
|
Thank you so much for the PR 🤩. We're adding the |
|
Closing stale PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Containerizes the website
(Provide a description of what this PR does.)
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
yes