Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 7353: Can't close execute function modal #711

Conversation

sourabpramanik
Copy link
Contributor

What does this PR do?

This PR fixes the close action for the function modal using the modal header close icon.
fix

Fixes #854

Test Plan

Manual

Related PRs and Issues

Have you read the [Contributing Guidelines on issues]

Yes

Copy link

vercel bot commented Jan 6, 2024

@sourabpramanik is attempting to deploy a commit to the appwrite Team on Vercel.

A member of the Team first needs to authorize it.

@sourabpramanik
Copy link
Contributor Author

@stnguyen90 I have removed all the other commits meant for other PR. Again thanks for pointing that out, I'll be more careful now for such things.

Copy link

vercel bot commented Jan 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 8:42pm
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 8:42pm

@sourabpramanik
Copy link
Contributor Author

Hello @stnguyen90 can you please review this PR?

@stnguyen90 stnguyen90 requested review from TorstenDittmann and ArmanNik and removed request for ArmanNik and stnguyen90 February 12, 2024 23:13
@ArmanNik ArmanNik changed the base branch from main to cloud March 10, 2024 13:59
@ArmanNik ArmanNik merged commit b285a30 into appwrite:cloud Mar 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Can't close Execute function modal
2 participants