Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: github redirect closing wizard #534

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

TorstenDittmann
Copy link
Contributor

@TorstenDittmann TorstenDittmann commented Sep 7, 2023

What does this PR do?

  • the check for an external navigation was inaccurate and is replaced by willUnload, that is true if the navigation goes to an external page
Bildschirmaufnahme_2023-09-07_um_16.02.33.mov

Test Plan

  • manual

Have you read the Contributing Guidelines on issues?

@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 2:03pm
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 2:03pm
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 2:03pm

@TorstenDittmann TorstenDittmann merged commit 46c7f2f into main Sep 7, 2023
@TorstenDittmann TorstenDittmann deleted the fix-github-redirect-wizard branch September 7, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants