-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Bulk Deletion #485
Feat: Bulk Deletion #485
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
...console/project-[project]/databases/database-[database]/collection-[collection]/table.svelte
Show resolved
Hide resolved
...console/project-[project]/databases/database-[database]/collection-[collection]/table.svelte
Outdated
Show resolved
Hide resolved
...console/project-[project]/databases/database-[database]/collection-[collection]/table.svelte
Outdated
Show resolved
Hide resolved
...console/project-[project]/databases/database-[database]/collection-[collection]/table.svelte
Outdated
Show resolved
Hide resolved
...console/project-[project]/databases/database-[database]/collection-[collection]/table.svelte
Outdated
Show resolved
Hide resolved
type="checkbox" | ||
bind:this={element} | ||
bind:checked={value} | ||
on:invalid={handleInvalid} /> | ||
on:invalid={handleInvalid} | ||
on:click /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't on:click
have a handler ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, this forwards the event in case you need it
@@ -2,6 +2,7 @@ | |||
import type { Action } from 'svelte/action'; | |||
|
|||
export let isSticky = false; | |||
export let noMargin = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason we use noMargin=false
instead of margin=true
?
It's harder to parse through conditions when using double negatives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I do agree, this is something that's present console wise. If we change it here, we would have to change it everywhere, which is fine by me, but I'd like to run it by Torsten.
Also, if we do change it, I'd argue for hasMargin instead of just margin. Margin sounds like I'm going to pass in a numeric value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea sounds fair 👍 if this pattern is already being followed we can delay this decision for later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. Looks good otherwise 👌
What does this PR do?
Test Plan
Manual
Related PRs and Issues
Depends on #479
Have you read the Contributing Guidelines on issues?
Yes