-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
smtp update #384
smtp update #384
Changes from 37 commits
a948cb0
2116a7f
48a8a03
e24bd15
ea4fee2
8b52804
df4879d
a0c8eec
2a2eb7f
b8d2483
f7044ce
ceed967
2001c0e
fa21777
e518553
5c95ea1
c72fdc1
b9cb702
d5f08ae
28eb65b
1b7447d
8369b94
7e91411
3a27a00
4466cdd
84679cc
532dfe0
b43632d
fcee6f8
aba9aea
8b7fe92
ac13072
b5ecedc
d2088cf
ae33ba1
e719ea8
603323b
3797364
8911b89
2bd9dcc
9ba4cf1
d1edc8c
a0da0f0
0fa7a1d
f2ed6d1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,12 +5,16 @@ | |
export let dismissible = false; | ||
export let type: 'info' | 'success' | 'warning' | 'error' = 'info'; | ||
export let buttons: Buttons[] = []; | ||
export let isAction = false; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need this? I don't see where it's used. Also, it might not be clear to have two ways to control whether the action buttons show. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We needed it in some initial design but now is not needed for this specific branch :) |
||
export let isStandalone = false; | ||
|
||
const dispatch = createEventDispatcher(); | ||
</script> | ||
|
||
<section | ||
class="alert" | ||
class:is-action={isAction} | ||
class:is-standalone={isStandalone} | ||
class:is-success={type === 'success'} | ||
class:is-warning={type === 'warning'} | ||
class:is-danger={type === 'error'} | ||
|
@@ -39,7 +43,7 @@ | |
</h6> | ||
{/if} | ||
<p class="alert-message"><slot /></p> | ||
{#if buttons?.length} | ||
{#if buttons?.length && !isAction} | ||
<div class="alert-buttons u-flex"> | ||
{#each buttons as button} | ||
<button class="button is-text" on:click={button.method}> | ||
|
@@ -49,5 +53,14 @@ | |
</div> | ||
{/if} | ||
</div> | ||
{#if buttons?.length && isAction} | ||
<div class="alert-buttons u-flex u-gap-16 u-cross-child-center"> | ||
{#each buttons as button} | ||
<button class="button is-text" on:click={button.method}> | ||
<span class="text">{button.name}</span> | ||
</button> | ||
{/each} | ||
</div> | ||
{/if} | ||
</div> | ||
</section> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to change this before merge, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://www.npmjs.com/package/christy-console
@lohanidamodar you can use version 0..4.0