Skip to content

Commit

Permalink
Format OAuth2 provider name better
Browse files Browse the repository at this point in the history
Show provider name in the Console and use the provider key for
everything else.
  • Loading branch information
stnguyen90 committed Jul 20, 2023
1 parent 8fdaaf2 commit 29ec34b
Show file tree
Hide file tree
Showing 11 changed files with 18 additions and 32 deletions.
8 changes: 5 additions & 3 deletions src/lib/stores/oauth-providers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import Oidc from '../../routes/console/project-[project]/auth/oidcOAuth.svelte';
import Okta from '../../routes/console/project-[project]/auth/oktaOAuth.svelte';

export type Provider = Models.Provider & {
key: string;
icon: string;
docs?: string;
component?: typeof SvelteComponent;
Expand All @@ -23,11 +24,12 @@ export type Providers = {
const setProviders = (project: Models.Project): Provider[] => {
return (
project?.providers.map((n) => {
const p = n as Models.Provider & { key: string };
let docs: Provider['docs'];
let icon: Provider['icon'] = n.name.toLowerCase();
let icon: Provider['icon'] = p.key.toLowerCase();
let component: Provider['component'] = Main;

switch (n.name.toLowerCase()) {
switch (p.key.toLowerCase()) {
case 'amazon':
docs = 'https://developer.amazon.com/apps-and-games/services-and-apis';
break;
Expand Down Expand Up @@ -154,7 +156,7 @@ const setProviders = (project: Models.Project): Provider[] => {
}

return {
...n,
...p,
icon,
docs,
component
Expand Down
4 changes: 1 addition & 3 deletions src/routes/console/project-[project]/auth/appleOAuth.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,7 @@
<div>
<p>URI</p>
<CopyInput
value={`${
sdk.forConsole.client.config.endpoint
}/account/sessions/oauth2/callback/${provider.name.toLocaleLowerCase()}/${projectId}`} />
value={`${sdk.forConsole.client.config.endpoint}/account/sessions/oauth2/callback/${provider.key}/${projectId}`} />
</div>
</FormList>
<svelte:fragment slot="footer">
Expand Down
4 changes: 1 addition & 3 deletions src/routes/console/project-[project]/auth/auth0OAuth.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,7 @@
<div>
<p>URI</p>
<CopyInput
value={`${
sdk.forConsole.client.config.endpoint
}/account/sessions/oauth2/callback/${provider.name.toLocaleLowerCase()}/${projectId}`} />
value={`${sdk.forConsole.client.config.endpoint}/account/sessions/oauth2/callback/${provider.key}/${projectId}`} />
</div>
</FormList>
<svelte:fragment slot="footer">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,7 @@
<div>
<p>URI</p>
<CopyInput
value={`${
sdk.forConsole.client.config.endpoint
}/account/sessions/oauth2/callback/${provider.name.toLocaleLowerCase()}/${projectId}`} />
value={`${sdk.forConsole.client.config.endpoint}/account/sessions/oauth2/callback/${provider.key}/${projectId}`} />
</div>
</FormList>
<svelte:fragment slot="footer">
Expand Down
4 changes: 1 addition & 3 deletions src/routes/console/project-[project]/auth/gitlabOAuth.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,7 @@
<div>
<p>URI</p>
<CopyInput
value={`${
sdk.forConsole.client.config.endpoint
}/account/sessions/oauth2/callback/${provider.name.toLocaleLowerCase()}/${projectId}`} />
value={`${sdk.forConsole.client.config.endpoint}/account/sessions/oauth2/callback/${provider.key}/${projectId}`} />
</div>
</FormList>
<svelte:fragment slot="footer">
Expand Down
4 changes: 1 addition & 3 deletions src/routes/console/project-[project]/auth/mainOAuth.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,7 @@
<div>
<p>URI</p>
<CopyInput
value={`${
sdk.forConsole.client.config.endpoint
}/account/sessions/oauth2/callback/${provider.name.toLocaleLowerCase()}/${projectId}`} />
value={`${sdk.forConsole.client.config.endpoint}/account/sessions/oauth2/callback/${provider.key}/${projectId}`} />
</div>
</FormList>
<svelte:fragment slot="footer">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,7 @@
<div>
<p>URI</p>
<CopyInput
value={`${
sdk.forConsole.client.config.endpoint
}/account/sessions/oauth2/callback/${provider.name.toLocaleLowerCase()}/${projectId}`} />
value={`${sdk.forConsole.client.config.endpoint}/account/sessions/oauth2/callback/${provider.key}/${projectId}`} />
</div>
</FormList>
<svelte:fragment slot="footer">
Expand Down
10 changes: 4 additions & 6 deletions src/routes/console/project-[project]/auth/oidcOAuth.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,11 @@
</script>

<Modal {error} onSubmit={update} size="big" show on:close>
<svelte:fragment slot="header">{provider.name.toUpperCase()} OAuth2 Settings</svelte:fragment>
<svelte:fragment slot="header">{provider.name} OAuth2 Settings</svelte:fragment>
<FormList>
<p>
To use {provider.name.toUpperCase()} authentication in your application, first fill in this
form. For more info you can
To use {provider.name} authentication in your application, first fill in this form. For more
info you can
<a class="link" href={provider.docs} target="_blank" rel="noopener noreferrer"
>visit the docs.</a>
</p>
Expand Down Expand Up @@ -110,9 +110,7 @@
<div>
<p>URI</p>
<CopyInput
value={`${
sdk.forConsole.client.config.endpoint
}/account/sessions/oauth2/callback/${provider.name.toLocaleLowerCase()}/${projectId}`} />
value={`${sdk.forConsole.client.config.endpoint}/account/sessions/oauth2/callback/${provider.key}/${projectId}`} />
</div>
</FormList>
<svelte:fragment slot="footer">
Expand Down
4 changes: 1 addition & 3 deletions src/routes/console/project-[project]/auth/oktaOAuth.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,7 @@
<div>
<p>URI</p>
<CopyInput
value={`${
sdk.forConsole.client.config.endpoint
}/account/sessions/oauth2/callback/${provider.name.toLocaleLowerCase()}/${projectId}`} />
value={`${sdk.forConsole.client.config.endpoint}/account/sessions/oauth2/callback/${provider.key}/${projectId}`} />
</div>
</FormList>
<svelte:fragment slot="footer">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
on:click={() => {
selectedProvider = provider;
trackEvent(`click_select_provider`, {
provider: provider.name.toLowerCase()
provider: provider.key.toLowerCase()
});
}}>
<div class="image-item">
Expand Down
2 changes: 1 addition & 1 deletion src/routes/console/project-[project]/auth/updateOAuth.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export async function updateOAuth({
try {
await sdk.forConsole.projects.updateOAuth2(
projectId,
provider.name.toLowerCase(),
provider.key,
appId || undefined,
secret || undefined,
enabled
Expand Down

0 comments on commit 29ec34b

Please sign in to comment.