Skip to content

Phone auth metric rename #8648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Phone auth metric rename #8648

merged 2 commits into from
Sep 9, 2024

Conversation

shimonewman
Copy link
Contributor

What does this PR do?

(Provide a description of what this PR does and why it's needed.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@shimonewman shimonewman changed the base branch from main to 1.6.x September 9, 2024 12:56
Copy link

github-actions bot commented Sep 9, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
curl 8.5.0-r0 CVE-2024-2398 HIGH
curl 8.5.0-r0 CVE-2024-6197 HIGH
libcurl 8.5.0-r0 CVE-2024-2398 HIGH
libcurl 8.5.0-r0 CVE-2024-6197 HIGH
libexpat 2.6.2-r0 CVE-2024-45490 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45491 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45492 CRITICAL
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v25.0.1+incompatible CVE-2024-41110 CRITICAL
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.45.0 CVE-2023-47108 HIGH
stdlib 1.21.6 CVE-2024-24790 CRITICAL
stdlib 1.21.6 CVE-2023-45288 HIGH
stdlib 1.21.6 CVE-2024-34156 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link

github-actions bot commented Sep 9, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libexpat 2.6.2-r0 CVE-2024-45490 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45491 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45492 CRITICAL
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL
stdlib 1.21.11 CVE-2024-34156 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link

github-actions bot commented Sep 9, 2024

✨ Benchmark results

  • Requests per second: 1,660
  • Requests with 200 status code: 298,781
  • P99 latency: 0.081469256

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,660 1,683
200 298,781 302,935
P99 0.081469256 0.084056736

@christyjacob4 christyjacob4 merged commit c7dd857 into 1.6.x Sep 9, 2024
25 checks passed
@christyjacob4 christyjacob4 deleted the phone_auth_metric_rename branch September 9, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants