Skip to content

Allow execution filter attributes #7607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 25, 2024
Merged

Conversation

vermakhushboo
Copy link
Member

What does this PR do?

Allow executions to be filtered by attributes like status, trigger, path, duration etc.

Test Plan

Tested using client

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@eldadfux eldadfux added product / functions Fixes and upgrades for the Appwrite Functions. version / 1.6 labels Feb 19, 2024
'$id' => ID::custom('_key_requestPath'),
'type' => Database::INDEX_KEY,
'attributes' => ['requestPath'],
'lengths' => [Database::LENGTH_KEY],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the max length of the request path? Will it be under 255 characters ?

Copy link
Member Author

@vermakhushboo vermakhushboo Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, max length of requestPath can be 2048 characters. The max length of index can be 768 characters. What should it be set to?

Copy link
Member

@christyjacob4 christyjacob4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I believe we can target this to the 1.6 branch

@vermakhushboo vermakhushboo changed the base branch from main to 1.6.x March 20, 2024 18:25
@christyjacob4 christyjacob4 merged commit 88abc65 into 1.6.x Mar 25, 2024
21 checks passed
@christyjacob4 christyjacob4 deleted the feat-function-execution-filters branch March 25, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product / functions Fixes and upgrades for the Appwrite Functions.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants