-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Allow execution filter attributes #7607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
'$id' => ID::custom('_key_requestPath'), | ||
'type' => Database::INDEX_KEY, | ||
'attributes' => ['requestPath'], | ||
'lengths' => [Database::LENGTH_KEY], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the max length of the request path? Will it be under 255 characters ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, max length of requestPath can be 2048 characters. The max length of index can be 768 characters. What should it be set to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I believe we can target this to the 1.6 branch
What does this PR do?
Allow executions to be filtered by attributes like status, trigger, path, duration etc.
Test Plan
Tested using client
Related PRs and Issues
Checklist