Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update errors.php #5136

Closed
wants to merge 2 commits into from
Closed

Update errors.php #5136

wants to merge 2 commits into from

Conversation

vedant-z
Copy link

@vedant-z vedant-z commented Feb 16, 2023

What does this PR do?

Fixes #4519
(Provide a description of what this PR does and why it's needed.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@vedant-z
Copy link
Author

@stnguyen90 Please review this

@stnguyen90 stnguyen90 self-requested a review March 1, 2023 20:34
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! 🤯 We left some comments during the review, please check them out.


public function testCreateProjectDomain($data): array
{
$id = $data['projectId'] ?? '';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are style problems indicated by the lint errors. Would you please fix them so the CI job passes?

@stnguyen90
Copy link
Contributor

@vedant-z, would you please run the formatter to fix the styling errors?

FYI, I'll need to close this due to inactivity soon.

@stnguyen90
Copy link
Contributor

Closing due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Incorrect Error When Creating Duplicate Domain
2 participants