-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LD-144] Migrate to version catalog #168
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
trOnk12
force-pushed
the
chore/migrate_to_version_catalog
branch
from
October 31, 2023 14:43
f7ef736
to
2b9d49c
Compare
# Conflicts: # app/build.gradle # build.gradle
nowakweronika
changed the title
chore: migrate to version catalog
[LD-144] Migrate to version catalog
Nov 17, 2023
jacek-marchwicki
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
# Conflicts: # app-shared-tests/build.gradle # app/build.gradle # build.gradle
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull-Request
Description
Why?
Instead of manually specifying dependency names and versions in separate build files and having to update each entry individually when upgrading a dependency, we can establish a centralized version catalog for dependencies. This catalog can be referenced by various modules in a type-safe manner, with assistance from Android Studio.
What?
Add version catalog.
Links to related issues
Demo
As you can see, Android studio is very clever and can replace our dependency with new library catalog declaration ;)
How to test
Please build the app and play with it :) Nothing should change.
Documentation
Checklist
- [ ] Functionality is covered by unit tests- [ ] Functionality is covered by integration tests