Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LD-144] Migrate to version catalog #168

Merged
merged 17 commits into from
Nov 22, 2023

Conversation

trOnk12
Copy link
Contributor

@trOnk12 trOnk12 commented Oct 30, 2023

Pull-Request

Description

Why?

Instead of manually specifying dependency names and versions in separate build files and having to update each entry individually when upgrading a dependency, we can establish a centralized version catalog for dependencies. This catalog can be referenced by various modules in a type-safe manner, with assistance from Android Studio.

What?

Add version catalog.

Links to related issues

Demo

As you can see, Android studio is very clever and can replace our dependency with new library catalog declaration ;)

After the PR
Screenshot 2023-11-17 at 11 46 18

How to test

Please build the app and play with it :) Nothing should change.

Documentation

Checklist

- [ ] Functionality is covered by unit tests
- [ ] Functionality is covered by integration tests

  • I've updated PR description with relevant information
  • I've done self code review
  • I've manually tested if the code and app works

@trOnk12 trOnk12 marked this pull request as draft October 30, 2023 20:21
@github-actions
Copy link

github-actions bot commented Oct 30, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 2.95s
✅ REPOSITORY checkov yes no 12.9s
✅ REPOSITORY devskim yes no 1.11s
✅ REPOSITORY dustilock yes no 0.24s
✅ REPOSITORY gitleaks yes no 1.38s
✅ REPOSITORY git_diff yes no 0.07s
✅ REPOSITORY secretlint yes no 2.45s
✅ REPOSITORY syft yes no 0.61s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@trOnk12 trOnk12 force-pushed the chore/migrate_to_version_catalog branch from f7ef736 to 2b9d49c Compare October 31, 2023 14:43
@nowakweronika nowakweronika changed the title chore: migrate to version catalog [LD-144] Migrate to version catalog Nov 17, 2023
@nowakweronika nowakweronika marked this pull request as ready for review November 20, 2023 11:01
Copy link
Member

@jacek-marchwicki jacek-marchwicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

app-shared-tests/build.gradle Outdated Show resolved Hide resolved
app-shared-tests/build.gradle Outdated Show resolved Hide resolved
app-shared-tests/build.gradle Outdated Show resolved Hide resolved
Copy link

Overall Project 73.06%

There is no coverage information present for the Files changed

@nowakweronika nowakweronika merged commit 4d5324b into develop Nov 22, 2023
10 checks passed
@nowakweronika nowakweronika deleted the chore/migrate_to_version_catalog branch January 16, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants